Hotfix/dynatable i18n text duplication

[frenchbread]

Closes #785

Changes:

• Replace dynatable with datatables

Fixes:

• Language change

[jykae]

@frenchbread Reviewing

[jykae]

Original issue seems to be solved. However rendering in UI, timestamps, etc. still not very nice in Chrome at least. Should we work it on this PR or what are your thoughts @frenchbread ?

[jykae]

Decided to work on the CSS layout issues on this PR with @frenchbread
Marked WIP.

[frenchbread]

@jykae I am using this package here. The thing is that those options for pagination does not work. E.g ${'.datatable').dataTable() - works, $('.datatable').dataTable({"sPaginationType": "bs_two_button"}) - does not, gives an error.

[brylie]

@frenchbread the last commit on the Datatables package was Dec 11, 2014 @Jowin. Is there a more active package?

[frenchbread]

@jykae I've added changes. Please review. The only issue I'm getting now is when formatting unix timestamp it gives wierd year value: e.g: 9/08/48387 11:10:01

[jykae]

🆒 checking

@brylie good note about the package health and possible future support. EDIT: Ok, that was addressed already in commit 77ec71d

[frenchbread]

@brylie @jykae Latest commits contain different package. It's still datatables but official and native one for NPM.

[jykae]

Good work so far a bit beyond than the explanation in the PR.
Let's return to this tomorrow, I will check the server time settings and whether Umbrella has any issues related to this. For me it looks like you are doing the conversion anyway right with momentjs.

[frenchbread]

Removing WIP. Please review.

[jykae]

Checked in the review together, merging. Good work @frenchbread

[brylie]

Define this function in the onCreated callback, then call it from within this onRendered callback.

[frenchbread]

@brylie I think there is no need to move those functions because refreshTable() is wrapped into instance.renderCharts() which is already located in onCreated callback for initialisation. instance.renderCharts() is called from instance.getDashboardData() also in onCreated. But the intance.getDashboardData() itself with the entire functions is called from onRendered. So there should not be any rendering problems.

[brylie]

Part of modularizing the code will be to move nested functions to the template level. E.g. our code is hard to maintain and refactor, in part, because functions are defined and called inside of other functions.

[frenchbread]

@brylie Agreed. Created #1040 for that - feel free to extend def. of done. I'm thinking that we should move more to object-oriented approach there (to be able to easily reuse functions and add functionality if needed)