Hotfix/api umbrella methods sync

[frenchbread]

Fixes

• Closes baseUrl undefined when creating new apiBackend #1044
• Closes Refactor settings code to fix startup errors #1068
• Closes Cleanup JSON routes code, since we are not rewriting swagger baseUrl anymore #1069
• Api backends sync from ApiUmbrella

[frenchbread]

@apinf/developers Please review & test

[jykae]

@frenchbread Overall code and solution looked good. Settings file usage won't be anymore supported I suppose?

[frenchbread]

Yes. But basically, as I recall correctly there were some feature that transfers settings data from setting file to collection.

[brylie]

@frenchbread yes. We should probably still allow settings to be provided by settings.json, so in startup we could write the Meteor.settings object to the Settings collection. Everywhere else in the app, though, we should be getting settings from the Settings collection.

[jykae]

Not syncing, should I wait 5 mins, or still bug?

[jykae]

Add letter 'n' for everywhere this function gets called and function name.

apiUmbrellaSettigsValid => apiUmbrellaSettingsValid

[frenchbread]

Good catch.

[jykae]

Generally:
On startup with fresh database I guess we don't have Settings collection, only possible is settings file that could have been passed.

[jykae]

Decided together to leave settings file case outside of this.

[frenchbread]

Added some more refactoring & checks

[jykae]

Tested again after meteor reset, sync runs now without errors.

[jykae]

Added one more close to the description. Merging and closing.

If one minute syncing interval causes issues for example in production when there might be more latency let's make it longer.

Great co-working guys @frenchbread @brylie

[frenchbread]

@jykae @brylie 👍