Feature/api rating bookmark data model#1131
Conversation
| apiBackend.setAverageRating(); | ||
| }); | ||
| }, | ||
| setApiBackendAverageRating (apiBackendId) { |
There was a problem hiding this comment.
@brylie method name here could be something like set ApiBackendBookmarkCount
There was a problem hiding this comment.
Which method? The setApiBackendAverageRating is related to the averageRating field. Hence, this method is in the ratings.js file.
There was a problem hiding this comment.
@brylie Ok, I confused this because console.log says about bookmarks. Could you also cleanup/fix console.logs?
|
@brylie Overall nice work, other thing to fix before I merge this, EDIT: We need to decide if we continue to use percolate:migrations, package needs maintainer https://github.com/percolatestudio/meteor-migrations#call-for-maintainers |
…o feature/api-rating-bookmark-data-model
|
Ok, merging in, so I can integrate this to my table view. Thanks @brylie |
2 participants
Closes #1130
Proposed changes
averageRatingandbookmarkCountfields to ApiBackendssetAverageRatingcollection helper for ApiBackendsgetAverageRatingandgetBookmarkCounthelpers for ApiBackendssetAllApiBackendAverageRatingsmethod