Skip to content

Cleanup/GitHub onlogin hook#1186

Merged
frenchbread merged 2 commits intodevelopfrom
cleanup/github-onlogin-hook
Jun 21, 2016
Merged

Cleanup/GitHub onlogin hook#1186
frenchbread merged 2 commits intodevelopfrom
cleanup/github-onlogin-hook

Conversation

@jykae
Copy link
Copy Markdown
Contributor

@jykae jykae commented Jun 20, 2016

Closes #1126

Proposed changes

@jykae jykae added this to the Sprint 25 milestone Jun 20, 2016
@jykae
Copy link
Copy Markdown
Contributor Author

jykae commented Jun 20, 2016

onLogin hook seemed to be important anyway, added npm package, used import to get "Github not defined" exception away.

@frenchbread
Copy link
Copy Markdown
Contributor

👍

@frenchbread frenchbread merged commit a2dbd49 into develop Jun 21, 2016
@frenchbread frenchbread deleted the cleanup/github-onlogin-hook branch June 21, 2016 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exception in Github onLogin callback

2 participants