Conversation
Contributor
Author
|
@apinf/developers Please review. |
| instance.timeStart = new Date().getTime(); // Timer | ||
|
|
||
| const params = { | ||
| size: 50000, |
Contributor
There was a problem hiding this comment.
Should this still be hard-coded?
Contributor
Author
There was a problem hiding this comment.
@brylie I think so for now. Otherwise we could add an input field to the UI, to allow user provide custom limit. That will probably affect design of the wireframes.
| var timeScale = parsedData.timeScale; | ||
| var overviewChart = dc.barChart("#overview-chart"); | ||
| var moveChart = dc.barChart("#move-chart"); | ||
| const { |
|
|
||
| // Format the timestamp using Moment.js format method | ||
| timeStamp = timeStamp.format(); | ||
| const binwidth = 100; // Init binwidth for a bar chart |
Contributor
There was a problem hiding this comment.
Consider changing this to 50, to see how it looks.
| </div> | ||
| </div> | ||
| <template name="statusCodeCountsChart"> | ||
| <h4>HTTP Status Codes</h4> |
Contributor
Author
|
Added suggested changes. |
Contributor
|
This looks good. @NNN would you like to review this PR, since it is related to your re-design work? |
added 2 commits
July 1, 2016 15:34
Contributor
|
I have merged develop. Looks good. All other improvements I will add as a separate PR. |
Contributor
|
Merging this. There is going to a separate task to finalize this admin dashboard look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1040, #1105, #1066, #1145, #1144, #1245, #681, #680, #675, #672