Conversation
|
@brylie I added some of the tags. For autoforms, I am not sure how to add tags for the dropdown options, such as for the Send Feedback form. |
|
We can merge this PR when all related issues have been linked. E.g. add multiple 'Closes #issue' to the PR description, each 'Closes' on its own line: |
| "elasticsearch": "^11.0.1", | ||
| "github": "^1.4.0", | ||
| "jquery": "<3.0.0", | ||
| "jquery": "^2.2.4", |
There was a problem hiding this comment.
Is there some reason we are not using jquery 3.x ? Is something breaking?
There was a problem hiding this comment.
At one point, we had to pin our jQuery version to less than 3, so that Bootstrap would work. Bootstrap < 3.3.7 did not support jQuery version 3.x. We are now using bootstrap 3.3.7, so can use jQuery 3.x.
bootstrap.js:15 Uncaught Error: Bootstrap's JavaScript requires jQuery version 1.9.1 or higher, but lower than version 3(anonymous function) @ bootstrap.js:15(anonymous function) @ bootstrap.js:17(anonymous function) @ twbs_bootstrap.js?hash=dc805bf…:2394(anonymous function) @ twbs_bootstrap.js?hash=dc805bf…:2401
See the following issue / PR:
|
@Alapan Reviewing.. Code looks good. I was just wondering one thing why we have limited jQuery to 2.x ? Is there something breaking when using 3.x ? But it is not blocking merging of this, if not sure. |
|
@Alapan If interested to translate autoforms, we have this package in project, https://github.com/gwendall/meteor-autoform-i18n |
|
Well done. |
Closes #1278
Closes #1279
Closes #1280