Skip to content

Add i18n tags#1427

Merged
jykae merged 3 commits intodevelopfrom
feature/i18n-strings
Aug 23, 2016
Merged

Add i18n tags#1427
jykae merged 3 commits intodevelopfrom
feature/i18n-strings

Conversation

@Alapan
Copy link
Copy Markdown
Contributor

@Alapan Alapan commented Aug 20, 2016

Closes #1278
Closes #1279
Closes #1280

@Alapan
Copy link
Copy Markdown
Contributor Author

Alapan commented Aug 21, 2016

@brylie I added some of the tags. For autoforms, I am not sure how to add tags for the dropdown options, such as for the Send Feedback form.

@brylie
Copy link
Copy Markdown
Contributor

brylie commented Aug 22, 2016

@Alapan great work! To help us better track the translation process, please also reference the sub-tasks of #965 that this completes. You can see the sub-tasks that are linked to #965 by scrolling down in the comments section and looking for the 'open' label next to related issues.

@brylie brylie self-assigned this Aug 22, 2016
@brylie brylie added this to the Sprint 29 milestone Aug 22, 2016
@brylie
Copy link
Copy Markdown
Contributor

brylie commented Aug 22, 2016

We can merge this PR when all related issues have been linked. E.g. add multiple 'Closes #issue' to the PR description, each 'Closes' on its own line:

Closes #123
Closes #234
Closes #345
...

@brylie brylie assigned jykae and unassigned brylie Aug 23, 2016
"elasticsearch": "^11.0.1",
"github": "^1.4.0",
"jquery": "<3.0.0",
"jquery": "^2.2.4",
Copy link
Copy Markdown
Contributor

@jykae jykae Aug 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some reason we are not using jquery 3.x ? Is something breaking?

Copy link
Copy Markdown
Contributor

@brylie brylie Aug 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At one point, we had to pin our jQuery version to less than 3, so that Bootstrap would work. Bootstrap < 3.3.7 did not support jQuery version 3.x. We are now using bootstrap 3.3.7, so can use jQuery 3.x.

bootstrap.js:15 Uncaught Error: Bootstrap's JavaScript requires jQuery version 1.9.1 or higher, but lower than version 3(anonymous function) @ bootstrap.js:15(anonymous function) @ bootstrap.js:17(anonymous function) @ twbs_bootstrap.js?hash=dc805bf…:2394(anonymous function) @ twbs_bootstrap.js?hash=dc805bf…:2401

See the following issue / PR:

@jykae
Copy link
Copy Markdown
Contributor

jykae commented Aug 23, 2016

@Alapan Reviewing.. Code looks good. I was just wondering one thing why we have limited jQuery to 2.x ? Is there something breaking when using 3.x ? But it is not blocking merging of this, if not sure.
I just run this after lunch, and see that everything functions nice.

@jykae
Copy link
Copy Markdown
Contributor

jykae commented Aug 23, 2016

@Alapan If interested to translate autoforms, we have this package in project, https://github.com/gwendall/meteor-autoform-i18n
It might provide some help for what you were wondering, if you look at the examples.

@jykae jykae merged commit c20d94e into develop Aug 23, 2016
@jykae jykae deleted the feature/i18n-strings branch August 23, 2016 10:46
@jykae jykae removed the in progress label Aug 23, 2016
@jykae
Copy link
Copy Markdown
Contributor

jykae commented Aug 23, 2016

Well done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants