Add ProxyBackends collection

[brylie]

Closes #1233
Closes #1344

Changes

• Add ProxyBackends collection
• Add ProxyBackends schema
• Add ApiUmbrellaSchema
• Add Proxy tab on view API Backend page
• Add Proxy Backend Configuration panel
• Add Proxy Backend configuration form
  • insert and update methods
  • labels, help texts, and validation messages
  • Regular expression for Proxy/API base path fields
• Add ApiProxyConfiguration publication/subscription
• Add i18n tokens/strings
• Cleanup
  • lint various files, as they are saved
  • Change apiBackend to api where possible
  • Refactor ApiMetadata collection to follow project filename convention

[jykae]

@brylie Is this going to be like this, that type of the proxy is hardcoded in schema? Or are you changing it?

[brylie]

@jykae we have decided to have specific fields based on the type of proxy, e.g. apiUmbrella.host.

This is similar to how @frenchbread implemented the Proxy feature, where he created sub-schemas for each supported proxy. Right now we are only aiming to support API Umbrella, but this approach allows us to easily enable more proxies.

[brylie]

Suggested changes made. Please review.

[brylie]

@frenchbread please also note that in your Proxy module we should have only one url field for API Umbrella. That url field should not allow values ending with /, or it should be cleaned up on submit.

We will be appending /api-umbrella/ within the API Umbrella Admin API integration methods.

[frenchbread]

That url field should not allow values ending with /, or it should be cleaned up on submit.

@brylie Does this require any changes for #1459 ?

[brylie]

@brylie Does this require any changes for #1459 ?

@frenchbread it looks like it. I will make some inline comments.

[frenchbread]

I'd suggest writing this helper shorter, e.g:

currentUserCanEdit () {
    const userId - Meteor.userId();
    if (userId) {
        const isManager = _.includes(this.managerIds, userId);
        const isAdmin = Roles.userIsInRole(userId, ['admin']);
        return (isManager || is Admin);
    }
    return false;
}

I think this looks more compact & easy to read 😃

[brylie]

Done.

[brylie]

@frenchbread I made the suggested changes. Please review.

[brylie]

I don't want to do the 'base path live preview' at this point, so that we can merge this work soon.

If desirable, we can file the 'base path live preview' as an enhancement task.

[frenchbread]

@brylie On Api details tab, shouldn't the the base URL display the actual URL for requests?

[frenchbread]

Everything else looks cool. Good job on refactoring bunch of files to fix eslist 👍

[bajiat]

@frenchbread There is a continuation task for the details tab. If that is the only thing missing, please merge this. Illya is waiting for this task to be merged.

[bajiat]

@frenchbread Is it possible for you to merge during the afternoon? If not, I can reassign the task

[frenchbread]

Ok, merging. @brylie @bajiat