Feature/eslint

[brylie]

Closes #1466

Changes

• Add ESLint to project dev dependencies
• Add Airbnb base rules
• Add Meteor lint rules
• Add Babel lint rules
• Ignore third party libraries in our sourcecode

[55]

@brylie, did next:

1. Installed https://github.com/AtomLinter/linter-eslint
2. meteor npm install
3. meteor npm run lint

Getting:
30009 problems (27804 errors, 2205 warnings)

[brylie]

@NNN jep. We have a lot of lint. I was able to get the number of errors down to around 5,000 by ignoring third party libraries:

5059 problems (4654 errors, 405 warnings)

[brylie]

Calling eslint --fix . reduces the number of issue by half:

2427 problems (2148 errors, 279 warnings)

From the ESLint Rules documentation:

The --fix option on the command line automatically fixes problems (currently mostly whitespace)

[frenchbread]

Tested. Works as expected! I would only suggest to add one rule: since we used to add spaces before function parenthesis, this helps :

package.json

"rules": {
      "space-before-function-paren": ["error", { "anonymous": "always", "named": "always" }]
    }

Source

[brylie]

@NNN and/or @frenchbread will this be merged today, or is more work needed?

[frenchbread]

Looks good to me. Unless you are still committing here, I'll merge this.

[brylie]

Cool. I don't have any more edits.