Skip to content

feature/api-settings-export-fixes#1497

Merged
55 merged 25 commits intodevelopfrom
feature/api-settings-export-fixes
Sep 15, 2016
Merged

feature/api-settings-export-fixes#1497
55 merged 25 commits intodevelopfrom
feature/api-settings-export-fixes

Conversation

@55
Copy link
Copy Markdown
Contributor

@55 55 commented Sep 7, 2016

Closes #1385

@55 55 added this to the Sprint 30 milestone Sep 7, 2016
@55 55 added the in progress label Sep 7, 2016
@55 55 changed the title hide export tab for not admins or owners feature/api-settings-export-fixes Sep 7, 2016
@brylie
Copy link
Copy Markdown
Contributor

brylie commented Sep 15, 2016

There are still some issues with the i18n keys, so please observe how other i18n keys are structured.

Also, make use of nesting to improve readability. Add a newline after HTML tags, so that child elements are indented one level.

@55
Copy link
Copy Markdown
Contributor Author

55 commented Sep 15, 2016

@brylie added suggested changes.

{{ # if api.currentUserCanEdit }}
<li>
<a href="#api-export" data-toggle="tab">
<a href="#api-backend-export" data-toggle="tab">
Copy link
Copy Markdown
Contributor

@brylie brylie Sep 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small detail, but the word 'backend' was removed on purpose, please revert -- and if possible, remove Backend from the template name too.

Basically, the word 'backend' is appearing in our code quite a lot, and is not really helping improve readability. We have been removing 'backend' and 'frontend' from our user interface and code, to the extent possible.

I can remove the 'backend' from viewApiBackend and all related i18n strings, if you will just clean up this part of the code.

@brylie
Copy link
Copy Markdown
Contributor

brylie commented Sep 15, 2016

This is really close.

One thing I have been trying to do is remove 'backend' from our code and user interface. It was used in a confusing manner for both end users and developers. We are switching to the following terminology for simplicity:

  • API - an API somewhere on the web, added to our catalogue
  • Proxy - an API Proxy solution, such as API Umbrella
  • ProxyBackend - an API that has been configured behind a proxy, hence 'backend'

We are only using 'backend' related to the third case, in order to distinguish it from a regular API, and to make it easier to describe our software.

@brylie
Copy link
Copy Markdown
Contributor

brylie commented Sep 15, 2016

I can make the above change, but it is important that we all know to limit the word 'backend'.

@55
Copy link
Copy Markdown
Contributor Author

55 commented Sep 15, 2016

@brylie, got it, thanks for the explanation.

@brylie
Copy link
Copy Markdown
Contributor

brylie commented Sep 15, 2016

@NNN I made the changes, renaming API related templates for consistency.

@brylie
Copy link
Copy Markdown
Contributor

brylie commented Sep 15, 2016

@NNN please review.

@55 55 merged commit 0b1ef77 into develop Sep 15, 2016
@55 55 deleted the feature/api-settings-export-fixes branch September 15, 2016 14:52
@55 55 removed the in progress label Sep 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants