Skip to content

Update docker image for api-umbrella#1537

Merged
brylie merged 1 commit intodevelopfrom
update-docker-compose-config
Sep 14, 2016
Merged

Update docker image for api-umbrella#1537
brylie merged 1 commit intodevelopfrom
update-docker-compose-config

Conversation

@shaliko
Copy link
Copy Markdown
Contributor

@shaliko shaliko commented Sep 11, 2016

  • Update docker image for api-umbrella to version 0.13.0
  • Split ElasticSearch fro api-umbrella to separate container.
  • Make ElasticSearch available only from private docker network (between containers).

Closes #1249

depends_on:
- apinf
elasticsearch:
image: elasticsearch:1.7.5
Copy link
Copy Markdown
Contributor

@brylie brylie Sep 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ElasticSearch 2 allowed, but by default api-umbrella use 1.7.5. Because we will migrate on use API instead of direct call to Elasticsearch, I decide keep default version.

But if you see any scenario where it will be useful I can migrate on 2.x.x

@brylie
Copy link
Copy Markdown
Contributor

brylie commented Sep 12, 2016

Well, lets go ahead and migrate to Elastic 2 now. It changes our analytics schema slightly, so we can make the changes sooner, rather than later.

@shaliko
Copy link
Copy Markdown
Contributor Author

shaliko commented Sep 12, 2016

@brylie After migrate to ElasticSearch 2, api-umbrella dashboard works OK (Analytics), but apinf-umbrella-dashboard dose not show data. Tomorrow will check with @marla-singer

@brylie
Copy link
Copy Markdown
Contributor

brylie commented Sep 13, 2016

OK, thanks @shaliko. We may need to make an update to our dashboard code, to match the Elasticsearch data structure.

@brylie
Copy link
Copy Markdown
Contributor

brylie commented Sep 13, 2016

Please add the Ready for revies tag once you have spoken with @marla-singer

@shaliko
Copy link
Copy Markdown
Contributor Author

shaliko commented Sep 13, 2016

@brylie In debug session with @marla-singer we found the root case of issue:

"reason": "Result window is too large, from + size must be less than or equal to: [10000] but was [50000]. See the scroll api for a more efficient way to request large data sets. This limit can be set by changing the [index.max_result_window] index level parameter."

For work with old releases (docker images) I will add increase "max_result_window" on start ElasticSearch. But I am not sure that we really need 50000 value.

@shaliko shaliko force-pushed the update-docker-compose-config branch from 95b1695 to bb70262 Compare September 13, 2016 15:38
@shaliko shaliko force-pushed the update-docker-compose-config branch from bb70262 to 08384bc Compare September 13, 2016 15:39
@shaliko shaliko force-pushed the update-docker-compose-config branch from 08384bc to 92dcc5f Compare September 14, 2016 08:20
@brylie brylie merged commit 813c31b into develop Sep 14, 2016
@shaliko shaliko deleted the update-docker-compose-config branch September 14, 2016 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants