Skip to content

Bugfix/enable GitHub settings#1593

Merged
brylie merged 3 commits intodevelopfrom
bugfix/enable-github-settings
Sep 16, 2016
Merged

Bugfix/enable GitHub settings#1593
brylie merged 3 commits intodevelopfrom
bugfix/enable-github-settings

Conversation

@jykae
Copy link
Copy Markdown
Contributor

@jykae jykae commented Sep 15, 2016

Closes #1591

Proposed changes

  • make Github settings function Meteor method
  • call method on settings form onSuccess hook to update Github settings

@jykae
Copy link
Copy Markdown
Contributor Author

jykae commented Sep 15, 2016

@apinf/developers please review, fixes regression

One small cave-eat, that has been probably earlier also.
If Github setting fields are saved blank, ServiceConfiguration does not get removed. But that could be enhancement if we make it possible to enable/disable also this Github login.

@brylie brylie self-assigned this Sep 16, 2016
@brylie brylie merged commit d489b47 into develop Sep 16, 2016
@brylie brylie deleted the bugfix/enable-github-settings branch September 16, 2016 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants