Conversation
Contributor
Author
|
@apinf/developers please review Ping @bajiat |
Contributor
|
@frenchbread Would you be available reviewing this PR ? Does not have to happen today, Monday is still ok. |
Contributor
|
Reassigned the task to @jykae |
Contributor
|
Reviewing |
Contributor
|
@brylie Onclick "add proxy":
|
Contributor
Author
|
@jykae please review. I added a fix for the #add-proxy event handler. |
Contributor
|
@brylie Form opened, but next one: And closer look: |
Contributor
Author
|
@jykae I added a check for |
Contributor
|
@brylie please eslint also your code
I am not requiring all of it from proxies.js, as you did not from me, but fix some, so that we have equal rules. |
Contributor
Author
|
@jykae I linted the proxies.js file. Please review. |
Contributor
|
Cool, were done here :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1532
Closes #1596
Changes
proxiesCountpublicationproxiesCountpublication to control item visibilityproxyIsConfiguredhelperproxyIsConfiguredhelper