Skip to content

Feature/delete account fix#1599

Merged
marla-singer merged 12 commits intodevelopfrom
feature/delete-account-fix
Sep 19, 2016
Merged

Feature/delete account fix#1599
marla-singer merged 12 commits intodevelopfrom
feature/delete-account-fix

Conversation

@brylie
Copy link
Copy Markdown
Contributor

@brylie brylie commented Sep 16, 2016

Closes #1477
Closes #1598

Changes

  • redirect user to home page when deleting account
  • fix navigation menu title link to home page

@brylie brylie added this to the Sprint 31 milestone Sep 16, 2016
@brylie
Copy link
Copy Markdown
Contributor Author

brylie commented Sep 16, 2016

@apinf/developers please review.

Ping @bajiat

@bajiat
Copy link
Copy Markdown
Contributor

bajiat commented Sep 19, 2016

@marla-singer Could you review this?

@marla-singer
Copy link
Copy Markdown
Contributor

@bajiat Yes. I'm going to review it after lunch

@marla-singer marla-singer self-assigned this Sep 19, 2016
@marla-singer
Copy link
Copy Markdown
Contributor

@brylie Please add sAlert to display successful dialog after deleting account and I'll merge it

@brylie
Copy link
Copy Markdown
Contributor Author

brylie commented Sep 19, 2016

@marla-singer done. Please review.

@marla-singer
Copy link
Copy Markdown
Contributor

@brylie Looks good. Merge it

@marla-singer marla-singer merged commit 447a405 into develop Sep 19, 2016
@marla-singer marla-singer deleted the feature/delete-account-fix branch September 19, 2016 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix navigation menu 'home' link when no logo is availale 'Delete' account not responding

4 participants