Conversation
1f603e0 to
d8dab67
Compare
|
Reviewing |
|
@marla-singer Rendering stuck Added first Swagger, then Proxy backend |
|
@jykae Describe please your steps |
|
@jykae It could be problem with node packages version. Can you please delete the folder "node_modules", run |
|
@jykae I found another problem. I'll write you after fixes |
|
@jykae Test please with api key too. I pushed fixes |
|
@marla-singer do you have steps how it should work with swagger? |
|
@jykae Add steps on PR description |
|
Cool, it works! :) |
|
@marla-singer Also eslint your code for "swaggerUiContent.js" for example. After some eslinting I think this is ready to merge. |
|
@jykae lint. However I don't know what to do with problems like "Template is not defined", "Meteor is not defined", "Unexpected dangling '_' in '_id' " |
|
@marla-singer If you are using eg. Atom you can click those errors and it opens to browser a page about error and examples how to correct. Eg. How to fix undefined classes & variables: Clicking "no-undef" would give link: http://eslint.org/docs/rules/no-undef There are some cases we need to allow in our rules like underscore-dangle in front of "id" that our DB objects use. If you find that kind of case that does not make sense, you can provide a fix to .eslintrc or just note reviewer so that it will eventually end up to allow if agreed so by higher orders :) Is it ok to fix those import things? Then I merge this in. |
|
@jykae Thank for your recommendations! I finished it |






Closes #1360
Testing api Key authorization
If it doesn't happen, close popup and open again.