Skip to content

Feature/update swagger host#1600

Merged
jykae merged 5 commits intodevelopfrom
feature/update-swagger-host
Sep 21, 2016
Merged

Feature/update swagger host#1600
jykae merged 5 commits intodevelopfrom
feature/update-swagger-host

Conversation

@marla-singer
Copy link
Copy Markdown
Contributor

@marla-singer marla-singer commented Sep 16, 2016

Closes #1360

Testing api Key authorization

  1. Add Swagger file which is supported Authorization. For example http://petstore.swagger.io/v2/swagger.json
  2. Go to API details and click on button "Get API Key"
  3. Go to Documentation tab and click on button "Authorization"
  4. Popup will be showed as on screenshot, field "value" contains the value of api key.
    If it doesn't happen, close popup and open again.
    joxi_screenshot_1474370327740

@jykae
Copy link
Copy Markdown
Contributor

jykae commented Sep 20, 2016

Reviewing

@jykae
Copy link
Copy Markdown
Contributor

jykae commented Sep 20, 2016

@marla-singer Rendering stuck Added first Swagger, then Proxy backend

nayttokuva 2016-09-20 kello 10 47 55

@marla-singer
Copy link
Copy Markdown
Contributor Author

@jykae Describe please your steps

@marla-singer
Copy link
Copy Markdown
Contributor Author

@jykae Also ping me if you face this issue #1588 (it'll be great if you can describe to me when this issue is appeared because I can't catch it)

@jykae
Copy link
Copy Markdown
Contributor

jykae commented Sep 20, 2016

This is possible related to issue:
nayttokuva 2016-09-20 kello 11 24 27

Coming from Swagger UI utils:
nayttokuva 2016-09-20 kello 11 25 42

Cannot parse securityDefinitions :/ I try one simpler without those if same issue.

@marla-singer
Copy link
Copy Markdown
Contributor Author

@jykae It could be problem with node packages version. Can you please delete the folder "node_modules", run npm i and try again?

@jykae
Copy link
Copy Markdown
Contributor

jykae commented Sep 20, 2016

@marla-singer
Copy link
Copy Markdown
Contributor Author

@jykae It's work correct on my side
joxi_screenshot_1474360997859

@jykae It could be problem with node packages version. Can you please delete the folder "node_modules", run npm i and try again?

Please try these recomendation

@marla-singer
Copy link
Copy Markdown
Contributor Author

@jykae I found another problem. I'll write you after fixes

@jykae
Copy link
Copy Markdown
Contributor

jykae commented Sep 20, 2016

Looks like it is basically built right.
nayttokuva 2016-09-20 kello 11 45 16

Did npm package updates.

@marla-singer
Copy link
Copy Markdown
Contributor Author

@jykae Test please with api key too. I pushed fixes

@jykae
Copy link
Copy Markdown
Contributor

jykae commented Sep 20, 2016

@marla-singer do you have steps how it should work with swagger?

@marla-singer
Copy link
Copy Markdown
Contributor Author

@jykae Add steps on PR description

@jykae
Copy link
Copy Markdown
Contributor

jykae commented Sep 20, 2016

Cool, it works! :)

@jykae
Copy link
Copy Markdown
Contributor

jykae commented Sep 20, 2016

@marla-singer Also eslint your code for "swaggerUiContent.js" for example.
We have recently started to require it in PRs. In our architect @brylie 's words "Fix at least some errors." As our .eslintrc is not yet fully proper, but we are going towards better code step by step.

nayttokuva 2016-09-20 kello 17 00 16

After some eslinting I think this is ready to merge.

@marla-singer
Copy link
Copy Markdown
Contributor Author

marla-singer commented Sep 20, 2016

@jykae lint. However I don't know what to do with problems like "Template is not defined", "Meteor is not defined", "Unexpected dangling '_' in '_id' "

@jykae
Copy link
Copy Markdown
Contributor

jykae commented Sep 21, 2016

@marla-singer If you are using eg. Atom you can click those errors and it opens to browser a page about error and examples how to correct.

Eg. How to fix undefined classes & variables:

import { Meteor } from 'meteor/meteor';
import { Template } from 'meteor/templating';

Clicking "no-undef" would give link: http://eslint.org/docs/rules/no-undef

There are some cases we need to allow in our rules like underscore-dangle in front of "id" that our DB objects use. If you find that kind of case that does not make sense, you can provide a fix to .eslintrc or just note reviewer so that it will eventually end up to allow if agreed so by higher orders :)

Is it ok to fix those import things? Then I merge this in.

@marla-singer
Copy link
Copy Markdown
Contributor Author

@jykae Thank for your recommendations! I finished it

@jykae jykae merged commit a3c8d9a into develop Sep 21, 2016
@jykae jykae deleted the feature/update-swagger-host branch September 21, 2016 07:59
@jykae jykae removed the in progress label Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update host name in Swagger file automatically

4 participants