Skip to content

Fix console errors after deleting api#1610

Merged
55 merged 2 commits intodevelopfrom
fix/deleting-api
Sep 22, 2016
Merged

Fix console errors after deleting api#1610
55 merged 2 commits intodevelopfrom
fix/deleting-api

Conversation

@marla-singer
Copy link
Copy Markdown
Contributor

@marla-singer marla-singer commented Sep 21, 2016

Closes #1519

@marla-singer
Copy link
Copy Markdown
Contributor Author

marla-singer commented Sep 21, 2016

@NNN Could you please review it?

@55 55 added this to the Sprint 31 milestone Sep 21, 2016
@55 55 self-assigned this Sep 21, 2016
@55
Copy link
Copy Markdown
Contributor

55 commented Sep 21, 2016

@marla-singer on it.

55
55 reviewed Sep 21, 2016
View reviewed changes
Copy link
Copy Markdown
Contributor

@55 55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. No more errors in the console.
Nice refactoring.

Please change i18n string I've mentioned and I will merge it.

core/lib/i18n/en.i18n.json Outdated
"deleteApiBackendConfirmation_deleteButton": "Delete",
"deleteApiBackendConfirmation_header": "Delete API",
"deleteApiBackendConfirmation_successMessage": "Successfully deleted API:",
"deleteApiConfirmation_CancelButton": "Cancel",
Copy link
Copy Markdown
Contributor

@55 55 Sep 21, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be cancelButton.

apis/client/delete/delete.html Outdated
<button type="button" class="btn btn-default" data-dismiss="modal">{{_ "deleteApiBackendConfirmation_CancelButton"}}</button>
<button type="button" class="btn btn-danger" id="deleteApi">{{_ "deleteApiBackendConfirmation_deleteButton"}}</button>
<button type="button" class="btn btn-default" data-dismiss="modal">
{{_ "deleteApiConfirmation_CancelButton"}}
Copy link
Copy Markdown
Contributor

@55 55 Sep 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here - cancelButton.

@marla-singer
Copy link
Copy Markdown
Contributor Author

marla-singer commented Sep 21, 2016

@NNN Done

@55
Copy link
Copy Markdown
Contributor

55 commented Sep 21, 2016

Also if there is an error or something prevents it from deleting, what will happen?
Will it be still redirecting to the catalogue? If so it will mislead users.

@marla-singer
Copy link
Copy Markdown
Contributor Author

marla-singer commented Sep 21, 2016

Before It was just console out with error message what isnot good too. I think we should create another issue which will be solve this scenario

@55
Copy link
Copy Markdown
Contributor

55 commented Sep 22, 2016

@marla-singer I am just not sure that it's the right way to clean those error. @brylie what do you think?

@brylie
Copy link
Copy Markdown
Contributor

brylie commented Sep 22, 2016

@NNN I think this is close enough for now. I see the original problem was with calling Router.go within the delete callback, which meant for an instance the client was viewing a deleted backend.

Lets merge the PR.

@55 55 merged commit 70d53b2 into develop Sep 22, 2016
@55 55 deleted the fix/deleting-api branch September 22, 2016 12:13
@55 55 removed the in progress label Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@55 55 55 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@55 55

Labels

Ready for review

Projects

None yet

Milestone

Sprint 31

Development

Successfully merging this pull request may close these issues.

4 participants

@marla-singer @55 @brylie @ilarimikkonen