Feature/disable api key bootstrap switch#1657
Conversation
proxy_backends/client/form/form.js
Outdated
| Template.proxyBackend.onRendered(() => { | ||
| // Make Disable API Key field easier to use | ||
| // Fixes browser rendering issue | ||
| $("[name='apiUmbrella.settings.disable_api_key']").bootstrapSwitch(); |
There was a problem hiding this comment.
I think that simple check / uncheck works much better here. bootstrapSwitch may work as a single element, but not as a part of a form.
There was a problem hiding this comment.
The checkbox is not working, for some reason, in Firefox 50.
The Bootstrap Switch allows the form to submit, and gives explicit text to let the user know about the field state:
There was a problem hiding this comment.
We can also refine the display of Bootstrap Switch as an enhancement.
There was a problem hiding this comment.
I made the button smaller.
There was a problem hiding this comment.
We disagree as to whether the button 'works' in the form, both literally and aesthetically.
|
After initial feedback, the button is now smaller. The on and off order was changed to improve readability:
This takes up a bit less space in the form, and matches the default state (off) in the ProxyBackend schema. |
|
There are a lot of Bootstrap Switch configuration options that we can use to enhance this task at a later point. |
|
@brylie Reviewing |
|
Kiitos @jykae |
|
@brylie tested on both Chrome & Firefox, works well. Merging. |
4 participants
Closes #1653
Closes #1656
Closes #1658
Changes