Conversation
|
@marla-singer please review. |
marla-singer
left a comment
marla-singer
left a comment
There was a problem hiding this comment.
Finished review. Tried to catch all places that need in refactoring too.
| name="apiDocumentationFile" | ||
| class="input-file" | ||
| type="file" | ||
| > |
There was a problem hiding this comment.
Check the indentation on this fragment. It may be sufficient to use two spaces for attribute enumeration
There was a problem hiding this comment.
This is fixed in a later commit. Please pull recent changes.
| {{#if api.currentUserCanEdit }} | ||
| {{> visibilityToggle api=api }} | ||
| {{/if }} | ||
| {{> visibilityToggle api=api }} |
There was a problem hiding this comment.
Why did you remove condition? It was added to don't show toggle to anonymous and non-owner
There was a problem hiding this comment.
Since it in settings view now, we don't need this check anymore.
backlog/client/list/list.html
Outdated
| <i>{{_ "apiBacklogList_noApiBacklogItemsFound"}}</i> | ||
| {{/if}} | ||
| {{> autoformModals }} | ||
| {{# if backlogItems}} |
There was a problem hiding this comment.
Forgot a space after helper name
catalogue/client/table/table.html
Outdated
| {{#each api in apis }} | ||
| {{#if api.currentUserCanView }} | ||
| {{# each api in apis }} | ||
| {{# if api.currentUserCanView }} |
There was a problem hiding this comment.
Check the indentation on this file. Condition is nested
| {{#autoForm collection=apisCollection doc=api id="apiDocumentationForm" type="update" }} | ||
| {{# autoForm | ||
| collection=apisCollection | ||
| doc=api id="apiDocumentationForm" |
There was a problem hiding this comment.
Separate this line to two lines too
feedback/client/form/form.html
Outdated
| {{_ "feedback_feedbackForm_description" }} | ||
| </p> | ||
| {{> afQuickField name='topic' }} | ||
| {{> afQuickField name='message' rows=4}} |
There was a problem hiding this comment.
Add a space after number '4'
feedback/client/list/list.html
Outdated
| type="button" | ||
| class="btn btn-info btn-xs pull-right feedback-form-button" | ||
| id="add-feedback" | ||
| > |
There was a problem hiding this comment.
Return the sign ">" on the previous line
proxies/client/form/form.html
Outdated
| {{# autoForm | ||
| collection=proxiesCollection | ||
| id="proxyForm" | ||
| type=formType doc=proxy}} |
There was a problem hiding this comment.
Separate this line to two lines too
There was a problem hiding this comment.
This is already done.
3 participants
Closes #1690
Closes #1643
Working through our codebase to improve the consistency of: