Skip to content

Hotfix/uploading swagger#1698

Merged
jykae merged 5 commits intodevelopfrom
hotfix/uploading-swagger
Oct 6, 2016
Merged

Hotfix/uploading swagger#1698
jykae merged 5 commits intodevelopfrom
hotfix/uploading-swagger

Conversation

@marla-singer
Copy link
Copy Markdown
Contributor

@marla-singer marla-singer commented Oct 5, 2016

Closes #1700
Closes #1701

@bajiat
Copy link
Copy Markdown
Contributor

bajiat commented Oct 6, 2016

@marla-singer: @jykae promised to mentor and review.

@bajiat bajiat added this to the Sprint 32 milestone Oct 6, 2016
@jykae
Copy link
Copy Markdown
Contributor

jykae commented Oct 6, 2016

Reviewing

@jykae
Copy link
Copy Markdown
Contributor

jykae commented Oct 6, 2016

@marla-singer #1701 seems to function right.

However with GPRS presets on I get this kind of situation, spinner spinning and resumable errors to console.
nayttokuva 2016-10-06 kello 16 01 01

Browser: Chrome 53.0.2785.116 (64-bit)
OS: macOS Sierra 10.12

@marla-singer
Copy link
Copy Markdown
Contributor Author

@jykae Please do screenshot Network tab then you upload file

@marla-singer
Copy link
Copy Markdown
Contributor Author

@jykae Which OS and browser do you use?

@jykae
Copy link
Copy Markdown
Contributor

jykae commented Oct 6, 2016

View with network tab open:
nayttokuva 2016-10-06 kello 16 34 45

@marla-singer
Copy link
Copy Markdown
Contributor Author

marla-singer commented Oct 6, 2016

@jykae Well, GPRS presets looks bad for testing feature. File's uploaded too slow. Time is out and connection closes 👎
please test it on "Regular 2G" presets. File will be uploaded ~2min

@jykae
Copy link
Copy Markdown
Contributor

jykae commented Oct 6, 2016

@marla-singer macOS Sierra is quite new, maybe it's related to Chrome on Sierra, error comes from resumable.js code. Check versions above in previous screenshot.
Maybe someone else could check with Chrome/Chromium, that is not on macOS Sierra.

EDIT: ok, I try out with "Regular 2G".

@jykae
Copy link
Copy Markdown
Contributor

jykae commented Oct 6, 2016

"Regular 2G" works as expected 👍

@marla-singer
Copy link
Copy Markdown
Contributor Author

marla-singer commented Oct 6, 2016

@jykae Aha, I think so. When I tested it on Hackintosh with macOS Sierra, i had this problem too. Connection opens only ~6 sec. But I slandered a pirated OS :D

@jykae
Copy link
Copy Markdown
Contributor

jykae commented Oct 6, 2016

@marla-singer I think we can merge this, if there's still issue let's open new one.

@jykae jykae merged commit 1f305f5 into develop Oct 6, 2016
@jykae jykae deleted the hotfix/uploading-swagger branch October 6, 2016 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants