Skip to content

Hotfix/dashboard not rendering#1745

Merged
brylie merged 5 commits intodevelopfrom
hotfix/dashboard-not-rendering
Oct 11, 2016
Merged

Hotfix/dashboard not rendering#1745
brylie merged 5 commits intodevelopfrom
hotfix/dashboard-not-rendering

Conversation

@frenchbread
Copy link
Copy Markdown
Contributor

@frenchbread frenchbread commented Oct 10, 2016

Closes #1721
Closes #1703

Changes

  • Added meteor method proxyBackendsAdded that checks if proxy backends added
  • Refactor & import deps for eslint
  • Show message to user if no proxy backends added

@brylie
Copy link
Copy Markdown
Contributor

brylie commented Oct 11, 2016

This appears to fix the errors. @frenchbread what is the status of this PR?

@brylie
Copy link
Copy Markdown
Contributor

brylie commented Oct 11, 2016

Also, have you tested that the charts work when analytics data is available? I am not able to render any charts. What proxy backends have you tested with?

@brylie brylie self-assigned this Oct 11, 2016
@brylie brylie added this to the Sprint 33 milestone Oct 11, 2016
@frenchbread
Copy link
Copy Markdown
Contributor Author

@brylie I did not see any charts rendered either, but I assume that there is no data in ES.

@brylie
Copy link
Copy Markdown
Contributor

brylie commented Oct 11, 2016

Ok, I have tested the charts to work.

One other thing, how can we get analytics for the /api-umbrella/ endpoint(s)?

screenshot_20161011_104652

I.e. Admin users might want to see analytics for the Admin API, and this gives us quite a bit of data to render our charts.

@brylie
Copy link
Copy Markdown
Contributor

brylie commented Oct 11, 2016

I have added the following option group to the select menu, but it does not work as expected:

<!-- Admin API -->
<optgroup label="Admin" >
  <option value="/api-umbrella/" >
    Admin API
  </option>
</optgroup>

@frenchbread
Copy link
Copy Markdown
Contributor Author

Probably we should hardcode the /api-umbrella/ in prefixesQuery variable to have it there.

@frenchbread
Copy link
Copy Markdown
Contributor Author

Please review

@brylie
Copy link
Copy Markdown
Contributor

brylie commented Oct 11, 2016

Sounds good. We need to make sure the user has an Admin role, before adding the /api-umbrella/ to the prefixes query. Can you do that as part of this PR please?

@frenchbread
Copy link
Copy Markdown
Contributor Author

This PR only shows a message to the user if proxy backends are not added, I think it should be that way

@brylie
Copy link
Copy Markdown
Contributor

brylie commented Oct 11, 2016

Actually, I will just review, since this is a hotfix. Can you consider opening a feature branch so that admins can access the Admin API analytics?

@brylie brylie merged commit dacb556 into develop Oct 11, 2016
@brylie brylie deleted the hotfix/dashboard-not-rendering branch October 11, 2016 07:56
@frenchbread
Copy link
Copy Markdown
Contributor Author

@brylie I got it working. I'll create a new issue & PR.

@brylie
Copy link
Copy Markdown
Contributor

brylie commented Oct 11, 2016

Yay! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants