Conversation
|
@apinf/developers please review |
|
@frenchbread this works, but there are some usability issues:
Example screenshotI made the above screenshot with the following code: <optgroup label="Administrator" >
<option value="/api-umbrella" >
Proxy Admin API
</option>
</optgroup> |
|
Ping @bajiat @philippeluickx |
|
@frenchbread basically, I think you can just wrap the above code example in an {{#if isInRole 'admin'}}
<optgroup label="Administrator" >
<option value="/api-umbrella" >
Proxy Admin API
</option>
</optgroup>
{{/ if }}Note: Be sure to include i18n tokens. |
|
@frenchbread after reviewing with @bajiat we think it would be good to remove the API Umbrella Logs option from the My APIs section, The menu should contain an Administrator section with Proxy Admin API section: |
|
@bajiat is this your understanding of our discussion? If so, this PR is really close to ready. |
|
So how much sections are we having in the end and why removing MyApis ? |
|
@frenchbread We are not suggesting to remove MyAPIs section. @brylie just had not added any APIs when he took the screenshot. |
|
Done |
|
@apinf/developers Please review |




Closes #1751
Changes
/api-umnrella/prefix to ES queryAPI Umbrella Logs