Show message on delete user account #1803
Merged
marla-singer merged 4 commits intodevelopfrom Oct 25, 2016
Merged
Conversation
core/lib/i18n/en.i18n.json
Outdated
| "deleteApiConfirmation_successMessage": "Successfully deleted API: ", | ||
| "deleteAccount_title": "Delete Account", | ||
| "deleteAccount_confirm_text": "Are you sure you want to delete your account?", | ||
| "deleteAccount_success_message": "User account deleted successfully.", |
Contributor
There was a problem hiding this comment.
You have duplication on 'deleteAccount_success_message'
Look at this: https://github.com/apinf/platform/blob/develop/core/lib/i18n/en.i18n.json#L194
added 2 commits
October 24, 2016 19:12
Contributor
Author
|
@marla-singer thanks for sharp eyes! Removed duplicate. Anything else? |
Contributor
|
@jykae Nope, as for me it works as expected. Merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1787