Skip to content

Add the new conditions and phrases for usage instruction#1810

Merged
jykae merged 2 commits intodevelopfrom
hotfix/usage-instruction
Oct 26, 2016
Merged

Add the new conditions and phrases for usage instruction#1810
jykae merged 2 commits intodevelopfrom
hotfix/usage-instruction

Conversation

@marla-singer
Copy link
Copy Markdown
Contributor

Closes #1759
Closes #1762

Implemented the scenario:

  1. If Proxy backend configuration is completed, "Disable API key" is false and user haven't got api key yet, usage instruction has message as "use your API key. Click the "Get API key" button to request the key"
  2. If Proxy backend configuration is completed, "Disable API key" is false and user has got api key, usage instruction has message as "use your API key in the URL parameters or in the request headers"
  3. If Proxy backend configuration is completed, "Disable API key" is true, usage instruction has message as "use the URL"

@marla-singer marla-singer added this to the Sprint 34 milestone Oct 25, 2016
@marla-singer
Copy link
Copy Markdown
Contributor Author

@brylie Could you please review it?

@jykae jykae self-assigned this Oct 26, 2016
@jykae
Copy link
Copy Markdown
Contributor

jykae commented Oct 26, 2016

Reviewing

@jykae
Copy link
Copy Markdown
Contributor

jykae commented Oct 26, 2016

@marla-singer works as described, what you think, could API key itself be also hidden from API view if "Disable API key requirement" is true for API? It could probably done easily with your new helpers. We can also put it as enhancement, as it is not described issue/task.
nayttokuva 2016-10-26 kello 9 02 25

@jykae
Copy link
Copy Markdown
Contributor

jykae commented Oct 26, 2016

@marla-singer We discussed this in daily, I merge this one and we'll do above thing if we get user feedback about it.

@jykae jykae merged commit 01e4d84 into develop Oct 26, 2016
@jykae jykae deleted the hotfix/usage-instruction branch October 26, 2016 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants