Skip to content

Fix bookmarks in IE11 #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jykae merged 2 commits into from
Oct 26, 2016
Merged

Fix bookmarks in IE11 #1818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f097808
Replace a tag to button
marla-singer Oct 25, 2016
11881b3
Change styles for button component
marla-singer Oct 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions apis/client/view/header/header.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,8 @@
font-size: 1em;
border: 1px solid #ddd;
border-radius: 3px;
a {
color: @gray;
text-decoration: none;
&:hover { text-decoration: none; color: @gray; }
&:focus { text-decoration: none; color: @gray; }
&:active { text-decoration: none; color: @gray; }
&:visited { text-decoration: none; color: @gray; }
button {
border: 0;
}

.bookmark-button {
Expand All @@ -71,11 +66,6 @@
padding-right: 0.9em;
padding-bottom: 0.5em;
padding-top: 0.5em;
text-decoration: none;
&:hover { text-decoration: none; color: darken(@gray, 10%); }
&:focus { text-decoration: none; color: darken(@gray, 10%); }
&:active { text-decoration: none; color: darken(@gray, 10%); }
&:visited { text-decoration: none; color: darken(@gray, 10%); }
}

.bookmark-counter {
Expand Down
8 changes: 4 additions & 4 deletions bookmarks/client/bookmark.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
<template name="bookmark">
{{# if isBookmarked }}
<a href="#" class="bookmark-button bookmark bookmarked">
<button class="bookmark-button bookmark bookmarked">
<i class="fa fa-bookmark"></i>
{{# unless catalogueView }}
&nbsp;{{_ "bookmark_buttonText_unbookmark" }}
{{/ unless }}
</a>
</button>
{{ else }}
<a href="#" class="bookmark-button bookmark">
<button class="bookmark-button bookmark">
<i class="fa fa-bookmark-o"></i>
{{# unless catalogueView }}
&nbsp;{{_ "bookmark_buttonText_bookmark" }}
{{/ unless }}
</a>
</button>
{{/ if }}
<span class="bookmark-counter">
{{ api.bookmarkCount }}
Expand Down
9 changes: 3 additions & 6 deletions catalogue/client/catalogue.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,8 @@
background-color: #fafafa !important;
}

.api-card-bookmark a {
.api-card-bookmark button {
color: @gray;
text-decoration: none;
&:hover { text-decoration: none; color: @gray; }
&:focus { text-decoration: none; color: @gray; }
&:active { text-decoration: none; color: @gray; }
&:visited { text-decoration: none; color: @gray; }
background-color: white;
border: 0;
}