Skip to content

Navbar & translations#1831

Merged
55 merged 6 commits intodevelopfrom
bugfix/navbar-i18n-signUp-login
Oct 28, 2016
Merged

Navbar & translations#1831
55 merged 6 commits intodevelopfrom
bugfix/navbar-i18n-signUp-login

Conversation

@jykae
Copy link
Copy Markdown
Contributor

@jykae jykae commented Oct 28, 2016

Closes #1319

  • fix navbar & footer i18n
  • deprecate homeHeader

@jykae jykae added this to the Sprint 34 milestone Oct 28, 2016
@jykae jykae changed the title signup & login translations Navbar & translations Oct 28, 2016
<i class="fa fa-plus" aria-hidden="true"></i>

{{_ "masterLayout_sidebar_AddAPIBackend" }}
{{_ "navbar_AddAPIBackend" }}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be "navbar_addAPIBackend"

<a href="{{ pathFor route='accountsAdmin' }}">
<i class="fa fa-users" aria-hidden="true"></i>
{{_ "masterLayout_sidebar_Users" }}
{{_ "navbar_Users" }}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be "navbar_users"

<a id="about-button">
<i class="fa fa-question-circle" aria-hidden="true"></i>
{{_ "navbar_aboutButton_text" }}
{{_ "navbar_About" }}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be "navbar_about"

@jykae
Copy link
Copy Markdown
Contributor Author

jykae commented Oct 28, 2016

@NNN requested changes done

@55 55 merged commit 082c846 into develop Oct 28, 2016
@55 55 deleted the bugfix/navbar-i18n-signUp-login branch October 28, 2016 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing i18n texts in navbar

2 participants