Skip to content

Move tests#1841

Merged
marla-singer merged 64 commits intodevelopfrom
feature/move-tests
Oct 31, 2016
Merged

Move tests#1841
marla-singer merged 64 commits intodevelopfrom
feature/move-tests

Conversation

@jykae
Copy link
Copy Markdown
Contributor

@jykae jykae commented Oct 28, 2016

Closes #1802

Proposed changes

sarala-codemenders and others added 30 commits December 1, 2015 15:46
This helps in testing the analytics of apinfw
Have updated the installation guide, based on the review inputs.
APInf Test Environment Setup Guide along with Test Scripts
…to testfix/viewapibackend-tests

# Conflicts:
#	test/viewapibackend.js
@jykae jykae added this to the Sprint 34 milestone Oct 28, 2016
test/common.js Outdated
},
signIn: function(driver) {
driver.get(this.url);
driver.findElement(By.linkText('login')).click();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jykae We will have problem in this place because now navbar has 'Sign in' button for login.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marla-singer well noticed, and that's what tests are good for, they fail if something is different. :)

@jykae
Copy link
Copy Markdown
Contributor Author

jykae commented Oct 31, 2016

Ran the whole test set:
nayttokuva 2016-10-31 kello 12 35 56

@marla-singer
Copy link
Copy Markdown
Contributor

marla-singer commented Oct 31, 2016

@jykae 8.1 test doesn't work as expected because we have an e-mail verification on nightly. Maybe it is also relating to 1.1 test

@jykae
Copy link
Copy Markdown
Contributor Author

jykae commented Oct 31, 2016

@marla-singer I ran this one against localhost as noticed email verifications are ON nightly.
EDIT: I can change localhost back to nightly if it's the environment we would like to run these tests.

Changing url of instance we are testing against should be simpler, as well as the login user that is expected to be "robot@test.com". We might need to come up with decision what is basically the instance we want to run these tests. If it's nightly we need to turn off email verifications OFF for registration tests. I can't think of possibility how we could test that automatically.

Basically here the task was to move tests & make it possible to run them using "npm test".

@jykae
Copy link
Copy Markdown
Contributor Author

jykae commented Oct 31, 2016

@marla-singer assign yourself if you would like to review this one. I propose that fixing tests would be in separate PRs, if something is needed.

@marla-singer marla-singer self-assigned this Oct 31, 2016
@jykae
Copy link
Copy Markdown
Contributor Author

jykae commented Oct 31, 2016

Github login above failed possibly because I had settings for Github wrong in localhost..

@marla-singer
Copy link
Copy Markdown
Contributor

@jykae Merge it.

@marla-singer marla-singer merged commit 50ae3cb into develop Oct 31, 2016
@marla-singer marla-singer deleted the feature/move-tests branch October 31, 2016 12:12
@brylie
Copy link
Copy Markdown
Contributor

brylie commented Oct 31, 2016

🔌 🍏 ⛵

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants