Github username taken

[jykae]

Closes #1864

[jykae]

works, but I clean it tomorrow

[brylie]

Would the following work here instead?

if (Meteor.user() && Meteor.user().username !== undefined) {
  ...
};

or, for example:

// Get user, if logged in - otherwise `null`
const user = Meteor.user();

if (user && user.username != undefined) {
  ...
};

• The !== undefined is more explicit
• since we are already relying on Meteor.user(), why introduce Meteor.userId()?
  • E.g. keep the code consistent by using only one Meteor.method()
• storing the user object, or undefined, in a temporary variable might also reduce the noise here
  • only use Meteor.. once
  • only one function call
• Meteor.user() should return null if user is not logged in

[jykae]

@brylie everything else I agree here but that explicitly saying "!== undefined", it should be common knowledge for JavaScript developer that it checks case "undefined", imho.

[brylie]

This is a nice improvement, and is generally very readable. 😎

[marla-singer]

@jykae Form allows me update profile without username

[marla-singer]

@jykae And can't navigate to Catalog and Add api page via navbar

[brylie]

@jykae we should also notify the user why they have been redirected to the profile page, if this is not already happening. Otherwise, it would be confusing:

why does it keep showing me the profile page:question:

-- confused user 😕

[marla-singer]

@brylie These has sAlert

[brylie]

Ah, I need to set my username, before I can add my "Gift Requests API" 🎁 ❗

-- santa claus 🎅

[marla-singer]

@brylie In PR #1859 I suggest to add popup like we have on Reset password. Maybe create another issue to improve an user usability?

[brylie]

Cool, it looks like this PR is headed in the right direction. ✈️

[jykae]

@marla-singer this logic setting for username if it is already taken has been like this for about year, as it was designed to function like this.
This PR was basically meant to fix just redirect as route for profile has been changed when we have improved settings, and some cleanup for router code.

If we need rethink usability add new issue.

[marla-singer]

@jykae Okay, put aside popup and user usability. But form allows user to update information with empty value

[jykae]

@marla-singer yep, I'm checking that one, good find 👍

[jykae]

Interesting we have separate template for username that does not seem to be included anywhere https://github.com/apinf/platform/tree/develop/users/client/account/username O_o

[jykae]

Also one other find, username also has different requirements on registration vs. profile form

[brylie]

Cool. Set optional: false in UserSchema.

[jykae]

@brylie I really hope it would be that simple. That solution provides "Internal server error" already in Github registration/login phase, when trying to create user, as username is required.

[jykae]

@marla-singer now it doesn't allow empty username, but shows "Please set username" 2 times on first redirect to profile. :) I can't see where this bug hides..

[jykae]

@marla-singer ready for review

thanks @brylie for bug-catching eyeglasses 8-)

[marla-singer]

@jykae I'll merge both branch on local and test

[marla-singer]

@jykae Detected problem and can't understand why.

1. Close all tab with site
2. Go to site again

Found from my side when router to site in first time:

• Empty main page, only navbar
• After refresh page, it's appeared for logined user
• After refresh page, it is not so for anonymous user
• After log in or navigate to Catalog, main page is appeared for anonymous user

Do you have something like this?

[jykae]

@marla-singer sorry, moved this.next outside if-statement, what about now?

[brylie]

This is an improvement in the function name. However, lets be just slightly more explicit, with something like:

• ensureUsernameExists
• ensureUserHasUsername

Using 'ensure' means that we are 'making sure' the user has a username, and is consistent with the ensureSignedIn function name.

[brylie]

Can't we do this easier by making username: { optional: false } in the user profile schema?

[jykae]

@brylie Different simplified approach, took away unnecessary complexity, cleaned up, ready for review.