Skip to content

Use bootstrap-datepicker for metadata Dates#1907

Merged
marla-singer merged 14 commits intodevelopfrom
feature/autoform-datepicker
Nov 14, 2016
Merged

Use bootstrap-datepicker for metadata Dates#1907
marla-singer merged 14 commits intodevelopfrom
feature/autoform-datepicker

Conversation

@jykae
Copy link
Copy Markdown
Contributor

@jykae jykae commented Nov 9, 2016

Closes #852
Closes #853
Closes #854

@jykae jykae added this to the Sprint 35 milestone Nov 9, 2016
@marla-singer marla-singer self-assigned this Nov 9, 2016
@marla-singer
Copy link
Copy Markdown
Contributor

@jykae Yeah, works good and error handler has too. If this type of date is acceptable, I will merge it
joxi_screenshot_1478700179991

@jykae
Copy link
Copy Markdown
Contributor Author

jykae commented Nov 9, 2016

@marla-singer I check tomorrow if I could possibly make it nicer. At least remove time part away.

@jykae
Copy link
Copy Markdown
Contributor Author

jykae commented Nov 11, 2016

@marla-singer date format improved

@marla-singer
Copy link
Copy Markdown
Contributor

@jykae Validate date isn't updated if I change only one date.
Steps: Enter both field: Validate since and Validate until, save it
Click on button "Edit metadata" and delete one of these fields, save it
Found: Fields aren't updated

But if you delete both fields, they'll disappear both

@jykae
Copy link
Copy Markdown
Contributor Author

jykae commented Nov 11, 2016

@marla-singer Good find, there is an open issue, Meteor-Community-Packages/meteor-autoform-bs-datepicker#24

I try to figure out something..

@marla-singer
Copy link
Copy Markdown
Contributor

@jykae I will approve it on Monday

@jykae
Copy link
Copy Markdown
Contributor Author

jykae commented Nov 14, 2016

Forked, fixed, published package with fix. https://github.com/apinf/meteor-autoform-bs-datepicker

@jykae
Copy link
Copy Markdown
Contributor Author

jykae commented Nov 14, 2016

@marla-singer how it feels now? does it function like expected?

@marla-singer
Copy link
Copy Markdown
Contributor

@jykae Unfortunatly no :( Now If Validate since and Validate util exist and I try to delete only Validate until then I have message about "End date must be after begin date"

@jykae
Copy link
Copy Markdown
Contributor Author

jykae commented Nov 14, 2016

@marla-singer how you would like it to behave? Only validate time frame if BOTH fields have value? And allow cases: only valid since value & only valid until value?

@marla-singer
Copy link
Copy Markdown
Contributor

@jykae Steps:

  1. Fill the fields "Valid since" and "Valid until" with the correct date
  2. Save forn
  3. Click on button "Edit metadata" and delete the value from "Valid until"
  4. Click on Save button

I've got the next results
2016-11-14 13 03 03

@jykae
Copy link
Copy Markdown
Contributor Author

jykae commented Nov 14, 2016

@marla-singer added check, now we compare only if we have both Dates. How about now?

@marla-singer
Copy link
Copy Markdown
Contributor

@jykae Good. Merge it

@marla-singer marla-singer merged commit 89a9cca into develop Nov 14, 2016
@marla-singer marla-singer deleted the feature/autoform-datepicker branch November 14, 2016 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants