Skip to content

Use ENV variable for flexible change docker tag name#1990

Merged
brylie merged 1 commit intodevelopfrom
update-travis-ci-settings
Jan 12, 2017
Merged

Use ENV variable for flexible change docker tag name#1990
brylie merged 1 commit intodevelopfrom
update-travis-ci-settings

Conversation

@shaliko
Copy link
Copy Markdown
Contributor

@shaliko shaliko commented Jan 11, 2017

The target: Fix issue with Travis config, after merge APIKA code to APINF. Now both projects generate "apika_develop" Docker image.

  • Use ENV variable for flexible change docker tag name for APINF and APIKA with TravisCI builds.
  • From now we can change $DOCKER_TAG ENV variable in TravisCI settings.

@brylie
Copy link
Copy Markdown
Contributor

brylie commented Jan 11, 2017

@shaliko can you please also open this PR against Apika? I want to avoid losing these changes.

@shaliko
Copy link
Copy Markdown
Contributor Author

shaliko commented Jan 12, 2017

@brylie I planned did APIKA PR after you will accept this one. git cherry pick + pull request.

@brylie brylie merged commit 0c6b28f into develop Jan 12, 2017
@brylie brylie deleted the update-travis-ci-settings branch January 12, 2017 09:24
@brylie brylie removed the ready label Jan 12, 2017
mauriciovieira pushed a commit to mauriciovieira/platform that referenced this pull request Jan 17, 2017
Use ENV variable for flexible change docker tag name
mauriciovieira pushed a commit to mauriciovieira/platform that referenced this pull request Jan 17, 2017
…is-ci-settings

Merge pull request apinf#1990 from apinf/update-travis-ci-settings
@mauriciovieira
Copy link
Copy Markdown
Contributor

It is also possible to use TRAVIS CI variables to have a different tag for each Pull Request, for instance. Is that desirable? For instance, we could docker push apinf/platform:${TRAVIS_BUILD_NUMBER} when building a Pull Request.

brylie added a commit that referenced this pull request Jan 23, 2017
Use ENV variable for flexible change docker tag name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants