Skip to content

Dashboard: the browser history#2088

Merged
brylie merged 6 commits intodevelopfrom
bugfix/dashboard-back-arrow
Feb 8, 2017
Merged

Dashboard: the browser history#2088
brylie merged 6 commits intodevelopfrom
bugfix/dashboard-back-arrow

Conversation

@marla-singer
Copy link
Copy Markdown
Contributor

Closes #2044

Solution

  1. Using FlowRouter.withReplaceState() to modify the current history entry instead of creating a new one. Link to Doc
  2. Initialize the query parameter in triggersEnter function to saving URL consistent. Because all query parameters excluding granularity are calculated in code.
    1. The next URL are the same for the browser history:
    • nightly.apinf.io/dashboard?backend=jwufbT5kXeDcP7mdP&granularity=month
    • nightly.apinf.io/dashboard?backend=jwufbT5kXeDcP7mdP&granularity=week
    1. The next URL are the different for the browser history
    • nightly.apinf.io/dashboard?backend=jwufbT5kXeDcP7mdP&granularity=month
    • nightly.apinf.io/dashboard?backend=MtejerXbEP92L5CJr&granularity=month

@marla-singer marla-singer changed the title Bugfix/dashboard back arrow Dashboard: the browser history Feb 8, 2017
@marla-singer marla-singer added this to the Sprint 36 milestone Feb 8, 2017
@marla-singer
Copy link
Copy Markdown
Contributor Author

@apinf/developers Ready for review

@brylie brylie self-assigned this Feb 8, 2017
@brylie brylie merged commit 82d52a2 into develop Feb 8, 2017
@brylie brylie deleted the bugfix/dashboard-back-arrow branch February 8, 2017 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants