Skip to content

Privacy & terms#2204

Merged
brylie merged 20 commits intodevelopfrom
feature/ui-pravicy-terms
Mar 3, 2017
Merged

Privacy & terms#2204
brylie merged 20 commits intodevelopfrom
feature/ui-pravicy-terms

Conversation

@55
Copy link
Copy Markdown
Contributor

@55 55 commented Mar 1, 2017

Closes #2122

@55 55 added the in progress label Mar 1, 2017
@55 55 added this to the Sprint 37 milestone Mar 1, 2017
@55
Copy link
Copy Markdown
Contributor Author

55 commented Mar 1, 2017

Does anybody @apinf/developers know where can I find this?

@brylie
Copy link
Copy Markdown
Contributor

brylie commented Mar 2, 2017

The configuration settings for our accounts templates can be found here:

Refer to the Accounts Temlates configuration guide to see how to add the privacy policy and terms URLs.

@55
Copy link
Copy Markdown
Contributor Author

55 commented Mar 2, 2017

Discussed with @brylie and we agreed to add rich text editor.
Will start with http://quilljs.com.


// If editor is empty (has only this empty div)
// see https://github.com/quilljs/quill/issues/1235
if (privacyPolicy === '<div><br></div>') {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than using a template helper to check for <div><br></div>, lets try an AutoForm.onSubmit hook to look for that string. If the privacyPolicy === '<div><br></div>', then set the field value to undefined.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For GitHub cross-reference, here is the Quill issue from this PR comment: slab/quill#1235

@brylie brylie self-assigned this Mar 3, 2017
@55
Copy link
Copy Markdown
Contributor Author

55 commented Mar 3, 2017

@brylie please review.

@brylie
Copy link
Copy Markdown
Contributor

brylie commented Mar 3, 2017

Looks good. We tried to update the branding doc to remove the <div><br /></div> before insert/update. However, the code was quickly looking a lot worse than the current implementation.

@brylie brylie merged commit d8dc4b4 into develop Mar 3, 2017
@brylie brylie deleted the feature/ui-pravicy-terms branch March 3, 2017 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants