Merged
Conversation
Contributor
|
@brylie Meteor can't start on my side |
marla-singer
suggested changes
Mar 1, 2017
| minifier-css@1.2.15 | ||
| minifier-js@1.2.15 | ||
| minimongo@1.0.19 | ||
| mizzao:sharejs@0.9.0 |
Contributor
There was a problem hiding this comment.
Let's pin this package
.meteor/versions
Outdated
| mongo-id@1.0.6 | ||
| mongo-livedata@1.0.12 | ||
| nimble:restivus@0.8.11 | ||
| nimble:restivus@0.8.12 |
Contributor
Author
There was a problem hiding this comment.
Yeah, I am getting a related console error:
TypeError: Cannot read property 'call' of undefined
at Restivus.<anonymous> (packages/nimble_restivus/lib/restivus.coffee:126:18)
at Array.forEach (native)
at Function._.each._.forEach (packages/underscore.js:139:11)
at Restivus.Assets.Restivus.Restivus.addCollection (packages/nimble_restivus/lib/restivus.coffee:120:9)
at meteorInstall.core.server.api.js (core/server/api.js:44:9)
Contributor
Author
|
@marla-singer I pinned nimble:restivus and mizzao:sharejs. Please review. |
Contributor
|
@brylie Works fine. It will be really good to have system testing for checking PR like this one ☂️ |
marla-singer
approved these changes
Mar 6, 2017
Contributor
|
I also want to test it before merging. Will do it now and let you know. |
Contributor
|
@brylie @marla-singer everything works as expected to me. |
55
approved these changes
Mar 6, 2017
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Meteor core and most dependencies.