Api Catalogue sort with i18n support#2243
Merged
marla-singer merged 4 commits intodevelopfrom Mar 9, 2017
Merged
Conversation
Contributor
|
@marla-singer Can I assign you as reviewer? @manzapanza Is this work in progress or ready for review? |
Contributor
Author
|
@bajiat is ready for review |
Contributor
|
@manzapanza Add |
Contributor
manzapanza
commented
Mar 7, 2017
package.json
Outdated
| "jquery": "^2.2.4", | ||
| "jquery-bbq": "^1.0.0", | ||
| "jquery.rateit": "^1.0.23", | ||
| "locale-compare-polyfill": "0.0.2", |
Contributor
There was a problem hiding this comment.
Exactly. Change order, add it after js-yaml
Contributor
Author
|
@marla-singer I ordered all packages by name |
Contributor
|
One way to check is to see that if the sorting language is English, Ä is equivalent to A and Ö is equivalent to O (accents are ignored), while if Finnish is the sorting language, Ä is after Z and Ö is after Ä. EnglishAid FinnishAid |
Contributor
|
@bajiat Thanks for clarification. So it works as expected for English and Finnish |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1303