Merged
Conversation
frenchbread
changed the title
Contributor
|
@frenchbread It is pretty common to version a ,some_dotfile.example in the repository of rails projects. I think we can leave a settings.json.example in the repository along with the README instructions. Would you like to do this? |
Contributor
|
@mauriciovieira, agree with you about settings.json.example file, but I think that is not a part of current PR. |
55
pushed a commit
that referenced
this pull request
Oct 15, 2015
Hotfix/hosts status check - closes #529
Contributor
Author
|
@mauriciovieira Like this idea. Gonna create a new issue for that. Do you think it is better to provide real paths like https://apinf.io and others for elasticsearch and apiUmbrella, or just leave them as https://example.com ? |
Contributor
|
@frenchbread just like it is written in the README ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mauriciovieira or @elnzv Please review this hotfix. I removed hard-coded urls for status checking. Please also refer to updated README.md file, now need to provide hosts for apinf as https://apinf.io and apiUmbrella as https://umbrella.apinf.io as separate fields.