Skip to content

Feature/unify api forms#660

Merged
frenchbread merged 24 commits intodevelopfrom
feature/unify-api-forms
Dec 1, 2015
Merged

Feature/unify api forms#660
frenchbread merged 24 commits intodevelopfrom
feature/unify-api-forms

Conversation

@55
Copy link
Copy Markdown
Contributor

@55 55 commented Nov 27, 2015

Closes #368

@55 55 added the in progress label Nov 27, 2015
@brylie brylie self-assigned this Nov 27, 2015
@55
Copy link
Copy Markdown
Contributor Author

55 commented Nov 27, 2015

@mauriciovieira and/or @frenchbread, could you please review this PR, since we were working on it together with Brylie?

@55 55 unassigned brylie Nov 27, 2015
@jykae
Copy link
Copy Markdown
Contributor

jykae commented Nov 27, 2015

@elnzv @brylie Will this fix issue https://github.com/apinf/api-umbrella-dashboard/issues/602 ? In version 0.1.0 the labels for Backend host & Frontend host should be switched, otherwise they go wrong when backend is sent to Umbrella.

@frenchbread
Copy link
Copy Markdown
Contributor

Found an issue:

If current user does not have a permission to edit an apiBackend -> page counties to load and no error (e.g. 404) is given.

If a backend, to which user is trying to navigate does not exist, error is also not given. Page infinitely continues to load.

@elnzv Could this one be fixed?

@frenchbread
Copy link
Copy Markdown
Contributor

Code looks good though!

@55
Copy link
Copy Markdown
Contributor Author

55 commented Dec 1, 2015

@frenchbread, same issue in develop branch.
I think we need to create a separate issue for this.

@frenchbread
Copy link
Copy Markdown
Contributor

Ok then. Merging this.

frenchbread added a commit that referenced this pull request Dec 1, 2015
@frenchbread frenchbread merged commit 56c90fe into develop Dec 1, 2015
@frenchbread frenchbread deleted the feature/unify-api-forms branch December 1, 2015 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants