Skip to content

Feature/cleanup config file #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brylie merged 4 commits into from
May 30, 2016
Merged

Feature/cleanup config file #970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c022fea
Cleanup config file
frenchbread May 26, 2016
6bd5218
Cleanup utils file
frenchbread May 26, 2016
2545bf2
Cleanup emails.js
frenchbread May 26, 2016
910e1e1
Fix feedback form submit
frenchbread May 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions lib/_config/_config.js
View file
Open in desktop

This file was deleted.

22 changes: 0 additions & 22 deletions lib/_config/emails.js
View file
Open in desktop

This file was deleted.

44 changes: 0 additions & 44 deletions lib/utils.js
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion server/methods/contactForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Meteor.methods({

// Send the e-mail
Email.send({
to: Settings.findOne().contactForm_toEmail,
to: Settings.findOne().contactForm.toEmail,
Copy link
Copy Markdown
Contributor

@brylie brylie May 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if this setting is not present? E.g. if the contact form 'to email' has not been provided in the settings collection? I suspect we will get an exception, which needs to be prevented or handled here.

Copy link
Copy Markdown
Contributor Author

@frenchbread frenchbread Jun 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we check if there is a value set in settings and if not, use email address from settings.json

from: doc.email,
subject: "Apinf Contact Form - Message From " + doc.name,
text: text
Expand Down