-
-
Notifications
You must be signed in to change notification settings - Fork 84
Allow users to config comma-separated namespaces for ApolloConfigChangeListener #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to config comma-separated namespaces for ApolloConfigChangeListener #11
Conversation
...t/src/main/java/com/ctrip/framework/apollo/spring/annotation/ApolloConfigChangeListener.java
Outdated
Show resolved
Hide resolved
|
Need to check why build for java 8 is failing.
https://github.com/apolloconfig/apollo-java/actions/runs/3779089827/jobs/6424087585 |
nobodyiam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I have submitted a #12 to fix the potential test error issue, you may update your branch with the latest code
- Please also help to update the usage example of
ApolloConfigChangeListener.javaand CHANGES.md.
apollo-client/src/main/java/com/ctrip/framework/apollo/spring/config/NamespaceHandler.java
Outdated
Show resolved
Hide resolved
fix potential test error issue
Codecov Report
@@ Coverage Diff @@
## main #11 +/- ##
============================================
+ Coverage 67.77% 68.16% +0.39%
- Complexity 1165 1175 +10
============================================
Files 165 165
Lines 5114 5124 +10
Branches 559 561 +2
============================================
+ Hits 3466 3493 +27
+ Misses 1381 1366 -15
+ Partials 267 265 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
...nt/src/main/java/com/ctrip/framework/apollo/spring/annotation/ApolloAnnotationProcessor.java
Outdated
Show resolved
Hide resolved
...nt/src/main/java/com/ctrip/framework/apollo/spring/annotation/ApolloAnnotationProcessor.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/com/ctrip/framework/apollo/spring/annotation/ApolloConfigChangeListener.java
Outdated
Show resolved
Hide resolved
nobodyiam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM

Another solution for. - #7