Skip to content

Conversation

@anandjoshisn
Copy link
Contributor

Another solution for. - #7

@anandjoshi91
Copy link
Contributor

anandjoshi91 commented Dec 26, 2022

Screen Shot 2022-12-26 at 13 38 28

Need to check why build for java 8 is failing.

Failures: Error: ConfigIntegrationTest.testGetConfigWithLocalFileAndWithRemoteConfig:168 expected:<[another]Value> but was:<[some]Value> Error: ConfigIntegrationTest.testGetConfigWithNoLocalFileAndRemoteConfigServiceRetry:297 expected:<someValue> but was:<null> Error: ConfigIntegrationTest.testGetConfigWithNoLocalFileAndRemoteMetaServiceRetry:282 expected:<someValue> but was:<null> Error: ConfigIntegrationTest.testGetConfigWithNoLocalFileButWithRemoteConfig:125 expected:<someValue> but was:<null> Error: ConfigIntegrationTest.testLongPollRefresh:372 expected:<someValue> but was:<null> Error: ConfigIntegrationTest.testLongPollRefreshWithMultipleNamespacesAndMultipleNamespaceNotified:459 expected:<someValue> but was:<null> Error: ConfigIntegrationTest.testLongPollRefreshWithMultipleNamespacesAndOnlyOneNamespaceNotified:413 expected:<someValue> but was:<null> Error: ConfigIntegrationTest.testOrderGetConfigWithLocalFileAndWithRemoteConfig:201 expected:<[another]Value> but was:<[some]Value> Error: Errors: Error: ConfigIntegrationTest.testOrderGetConfigWithNoLocalFileButWithRemoteConfig:148 » NoSuchElement Error: ConfigIntegrationTest.testRefreshConfig:343 » Timeout Waited 2500 milliseconds...

https://github.com/apolloconfig/apollo-java/actions/runs/3779089827/jobs/6424087585

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I have submitted a #12 to fix the potential test error issue, you may update your branch with the latest code
  2. Please also help to update the usage example of ApolloConfigChangeListener.java and CHANGES.md.

fix potential test error issue
@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Merging #11 (2bb6474) into main (041fdf4) will increase coverage by 0.39%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main      #11      +/-   ##
============================================
+ Coverage     67.77%   68.16%   +0.39%     
- Complexity     1165     1175      +10     
============================================
  Files           165      165              
  Lines          5114     5124      +10     
  Branches        559      561       +2     
============================================
+ Hits           3466     3493      +27     
+ Misses         1381     1366      -15     
+ Partials        267      265       -2     
Impacted Files Coverage Δ
...o/spring/annotation/ApolloAnnotationProcessor.java 91.96% <100.00%> (+0.78%) ⬆️
...rk/apollo/spring/property/SpringValueRegistry.java 83.78% <0.00%> (-5.41%) ⬇️
.../framework/apollo/spring/property/SpringValue.java 87.71% <0.00%> (-1.76%) ⬇️
.../apollo/internals/RemoteConfigLongPollService.java 80.83% <0.00%> (+2.39%) ⬆️
...va/com/ctrip/framework/apollo/util/ConfigUtil.java 86.84% <0.00%> (+4.21%) ⬆️
...rk/apollo/internals/DefaultMetaServerProvider.java 100.00% <0.00%> (+42.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@anandjoshisn anandjoshisn changed the title Provide optional param to inject comma separated namespaces Allow multiple comma separated namespaces to be resolved from a property Dec 27, 2022
@anandjoshisn anandjoshisn changed the title Allow multiple comma separated namespaces to be resolved from a property Allow users to config comma-separated namespaces for ApolloConfigChangeListener Dec 28, 2022
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit af2751f into apolloconfig:main Dec 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2022
@anandjoshi91 anandjoshi91 deleted the feature/issue/no/7-option2 branch January 2, 2023 15:00
@nobodyiam nobodyiam added this to the 2.1.0 milestone Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants