TSH-18123: Add UDS support for coprocessor communication#8348
Closed
theJC wants to merge 7 commits intoapollographql:devfrom
Closed
TSH-18123: Add UDS support for coprocessor communication#8348theJC wants to merge 7 commits intoapollographql:devfrom
theJC wants to merge 7 commits intoapollographql:devfrom
Conversation
7dc2e41 to
d6b34a2
Compare
Contributor
Author
|
@bnjjj - This is the PR I mentioned in person today. I do have an alternative branch that I had claude write for me that if you are interested to for inspiration for potential alternative avenue that could be considered, it leverages router's services/http that already has UDS support by adapting to it instead of whats done in this PR. Here's the potential other direction / alternative: #8389 |
10 tasks
d6b34a2 to
d3b4334
Compare
Contributor
|
@theJC I answered on the other PR, this one looks good but I think I would prefer to have the other implementation |
10 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #5739 / TSH-18123
Many of Apollo's customers using coprocessor will co-locate their coprocessor with their Router instance on the same host. (ie: within the same pod in kubernetes).
This PR brings parity to coprocessor communication with the Unix Domain Sockets support that both Router request ingress AND subgraph request egress have had for some time. Bypassing the full tcp/ip network stack and allowing data transfer between the Router and the coprocessor using memory space can significantly reduce latency compared to HTTP.
This has been successfully tested locally using a Spring Boot JVM coprocessor configured to listen via UDS.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩