Skip to content

feat(telemetry): add active subgraph requests attribute to router ove…#8530

Merged
mabuyo merged 3 commits intodevfrom
fix-doc-active-subgraph-requests
Nov 3, 2025
Merged

feat(telemetry): add active subgraph requests attribute to router ove…#8530
mabuyo merged 3 commits intodevfrom
fix-doc-active-subgraph-requests

Conversation

@faisalwaseem
Copy link
Contributor

Modified the selectors section to reflect the active_subgraph_requests properly


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@faisalwaseem faisalwaseem requested a review from a team as a code owner November 3, 2025 15:13
@apollo-librarian
Copy link

apollo-librarian bot commented Nov 3, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 1 changed, 0 removed
* graphos/routing/(latest)/observability/router-telemetry-otel/enabling-telemetry/selectors.mdx

Build ID: bede6912468739aecb1ad1cb
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/bede6912468739aecb1ad1cb

@github-actions

This comment has been minimized.

Copy link
Contributor

@mabuyo mabuyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the other attribute to keep it focused! Thanks for the change

@mabuyo mabuyo enabled auto-merge (squash) November 3, 2025 15:45
@mabuyo mabuyo merged commit 48bbf3d into dev Nov 3, 2025
15 checks passed
@mabuyo mabuyo deleted the fix-doc-active-subgraph-requests branch November 3, 2025 16:05
@abernix abernix mentioned this pull request Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants