fix: stop query planning compute jobs when parent task cancelled#8741
Merged
fix: stop query planning compute jobs when parent task cancelled#8741
Conversation
This comment has been minimized.
This comment has been minimized.
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: ad1d178a8faaf73a42992c1f |
aaronArinder
approved these changes
Dec 15, 2025
Contributor
aaronArinder
left a comment
There was a problem hiding this comment.
lgtm! I haven't tested it locally, but if you'd like me to, let me know; looks pretty safe overall, so didn't feel the need to hunt down an oom query for validation
Contributor
Author
I think it should be pretty safe as it requires experimental config, I've been testing a bunch more locally with the memory limit branch as well so confident it works |
briannafugate408
pushed a commit
that referenced
this pull request
Jan 9, 2026
briannafugate408
pushed a commit
that referenced
this pull request
Jan 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
To test locally, run a query that currently causes OOM with this in the config:
Check the memory usage of the router process, it should not continue to increase after the request/query planning is cancelled
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩