Skip to content

test: demand control non-clobbery#8840

Closed
aaronArinder wants to merge 25 commits intocaroline/demand-control-by-subgraphfrom
aaron/review-demand-control
Closed

test: demand control non-clobbery#8840
aaronArinder wants to merge 25 commits intocaroline/demand-control-by-subgraphfrom
aaron/review-demand-control

Conversation

@aaronArinder
Copy link
Contributor


adds a test that should fail if we change out dashmap for something dangerous when doing demand control (we probably wouldn't, but for whatever reason this is a weird itch for me)

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

carodewig and others added 25 commits January 23, 2026 12:16
chore: refactor config name to match convention
When different list size parameters are set (especially for specific subgraphs), it will radically change the estimated cost
these don't add anything, and they just slow down the run
@aaronArinder aaronArinder requested a review from a team January 28, 2026 19:10
@carodewig carodewig force-pushed the caroline/demand-control-by-subgraph branch from a2526bd to aee2352 Compare January 29, 2026 16:51
@carodewig carodewig requested a review from a team as a code owner January 29, 2026 16:51
@carodewig
Copy link
Contributor

Cherry-picked the commit because I made the mistake of rebasing 😱

@carodewig carodewig closed this Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants