Merged
Conversation
|
Why is the |
Author
|
@divyanshu013 I think that's how it works. An error is not an exception. 🤔 😄 I think some fetch libraries might have different implementation though. |
dhruvdutt
commented
Apr 20, 2018
package.json
Outdated
| { | ||
| "name": "appbase-js", | ||
| "version": "2.3.0", | ||
| "version": "2.3.1", |
Author
There was a problem hiding this comment.
Would this be a patch release or something else?
I hope it doesn't break things for those who depends on status 400 inside .on('data').
cc @divyanshu013 😋
divyanshu013
left a comment
divyanshu013
left a comment
There was a problem hiding this comment.
Looks good, if you can add tests for these cases that would be awesome 🔥
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36 #163