fix: add telemetry headers for appbase users only#83
Merged
Conversation
bietkul
suggested changes
Oct 14, 2021
Contributor
bietkul
left a comment
bietkul
left a comment
There was a problem hiding this comment.
Share a demo, how did you test the telemetry header?
src/core/api/getSuggestionsv3Api.js
Outdated
| }; | ||
| const headers = {}; | ||
|
|
||
| Object.assign(headers, { |
Contributor
There was a problem hiding this comment.
@mohdashraf010897 Use a utility method to get telemetry headers.
| @@ -9,20 +9,16 @@ import { btoa, removeUndefined } from '../../utils/index'; | |||
| * @param {String} args.path | |||
Contributor
There was a problem hiding this comment.
Why do we have changes in this file?
Member
Author
There was a problem hiding this comment.
I needed to pass headers(x-search-client) that were specific to certain methods calling the fetch function, so added a key called headers
bietkul
approved these changes
Oct 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
BugDescription:
Test Cases:
