Skip to content

ADFA-3412: Update Git-related texts with Git commands#1108

Merged
dara-abijo-adfa merged 4 commits into
stagefrom
ADFA-3412-update-git-terms
Mar 27, 2026
Merged

ADFA-3412: Update Git-related texts with Git commands#1108
dara-abijo-adfa merged 4 commits into
stagefrom
ADFA-3412-update-git-terms

Conversation

@dara-abijo-adfa
Copy link
Copy Markdown
Contributor

Replace "Download" with "Clone"

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 73111bb9-e9fd-4d2b-84eb-1d93e66b23ad

📥 Commits

Reviewing files that changed from the base of the PR and between 5bb324d and acb8aa3.

📒 Files selected for processing (1)
  • resources/src/main/res/values/strings.xml
🚧 Files skipped from review as they are similar to previous changes (1)
  • resources/src/main/res/values/strings.xml

📝 Walkthrough
  • Summary: Replaced "Download" with "Clone" in Git-related UI text and string resources; adjusted Git preference strings for capitalization and updated references in code and layout.

  • Changes

    • String resource renames/updates
      • download_git_projectclone_git_project ("Download a Git project" → "Clone a Git project")
      • download_projectclone_project ("Download project" → "Clone project")
      • Removed idepref_git_title; app now uses git_title ("Git")
      • Capitalized "Git" in:
        • idepref_git_summary → "Set and update Git configuration"
        • git_update_config_in_preferences → "You can update your Git configuration in Preferences"
    • Code & layout updates
      • app/src/main/java/com/itsaky/androidide/actions/main/CloneRepositoryAction.kt: action label now uses R.string.clone_git_project
      • app/src/main/java/com/itsaky/androidide/fragments/CloneRepositoryFragment.kt: primary button text now uses R.string.clone_project (retry case still uses R.string.retry)
      • app/src/main/java/com/itsaky/androidide/preferences/gitPrefExts.kt: GitPreferencesScreen title default updated to R.string.git_title
      • app/src/main/java/com/itsaky/androidide/adapters/EditorBottomSheetTabAdapter.kt: uses R.string.git_title for tab title
      • app/src/main/res/layout/fragment_clone_repository.xml: text bindings updated to @string/clone_git_project and @string/clone_project; android:id="@+id/tv_download_project" remains unchanged
  • Impact & scope

    • User-facing text-only changes: no control flow, state, or runtime behavior changes detected.
    • Files affected: string resources (including resource values files), one layout, and several Kotlin files that display these strings.
  • Risks / best-practice notes

    • i18n / translations: Renaming string keys breaks all existing localized resource files until they are updated. The repo contains many locale-specific resources (resources/src/main/res/values-*/strings.xml) that still reference the old keys or lack the new keys—update translations to avoid missing-text fallbacks.
    • External references: Any external modules, tests, scripts, or plugins referencing old resource keys (download_git_project, download_project, idepref_git_title) will fail. Perform a repository-wide search for these keys outside the changed files.
    • View id consistency: The layout retains the view id tv_download_project. If tooling or tests rely on naming consistency, either rename the id to reflect "clone" or confirm there are no dependencies on the id name.
    • Resource removal: Removing idepref_git_title requires verifying no runtime code or reflection expects that resource name.
  • Verification / recommended checks

    • Search repo for old keys and update remaining occurrences: download_git_project, download_project, idepref_git_title.
    • Update all localized resource bundles to include the new keys (clone_git_project, clone_project, git_title).
    • Run UI/smoke tests and any tests that reference string resources or view ids (tv_download_project) to confirm no regressions.
    • Manual spot-check: open Clone Repository UI flows and Git Preferences to confirm displayed text matches expectations.

Walkthrough

This PR renames several user-facing Git string resources and updates their usages: "download" → "clone" across action label, fragment UI, layout, and preferences title/captions. No behavioral, control-flow, or API changes were made.

Changes

Cohort / File(s) Summary
Git Repository Action
app/src/main/java/com/itsaky/androidide/actions/main/CloneRepositoryAction.kt
Action label resource changed from R.string.download_git_projectR.string.clone_git_project.
Clone Repository UI
app/src/main/java/com/itsaky/androidide/fragments/CloneRepositoryFragment.kt, app/src/main/res/layout/fragment_clone_repository.xml
Primary button and descriptive text updated: R.string.download_projectR.string.clone_project and layout string refs switched to clone_*.
Git Preferences
app/src/main/java/com/itsaky/androidide/preferences/gitPrefExts.kt
Preferences screen title default updated from R.string.idepref_git_titleR.string.git_title.
String Resources
resources/src/main/res/values/strings.xml
Renamed string IDs: download_git_projectclone_git_project, download_projectclone_project; removed idepref_git_title; capitalization fixes in Git-related summaries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • jatezzz
  • Daniel-ADFA
  • itsaky-adfa

Poem

🐰 I hopped through strings both old and new,
Swapped "download" for a sprightly "clone" in view.
Buttons now whisper the proper tune,
A tiny change beneath the moon,
Carrots clapped — the text is true. 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title references updating Git-related texts and Git commands, which aligns with the changeset that replaces 'Download' with 'Clone' terminology and updates Git preference labels.
Description check ✅ Passed The description 'Replace "Download" with "Clone"' directly describes the main objective and core changes across all modified files in the pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ADFA-3412-update-git-terms

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dara-abijo-adfa dara-abijo-adfa marked this pull request as draft March 24, 2026 12:49
@dara-abijo-adfa dara-abijo-adfa marked this pull request as ready for review March 24, 2026 17:06
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
resources/src/main/res/values/strings.xml (1)

1173-1193: ⚠️ Potential issue | 🟡 Minor

Update "connection_lost" string to use "cloning" instead of "download" for terminology consistency.

The string connection_lost is used in CloneRepositoryViewModel.kt during clone exception handling. Since the clone operation is now referred to as "Clone project" (not download), the error message should say "Connection lost during cloning" instead of "Connection lost during download" for consistency.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@resources/src/main/res/values/strings.xml` around lines 1173 - 1193, Update
the "connection_lost" string resource value to use "cloning" instead of
"download" so the wording matches the clone flow used in
CloneRepositoryViewModel.kt; locate the string with name "connection_lost" in
strings.xml and change its text to "Connection lost during cloning. Please check
your internet connection and try again." ensuring the exact punctuation and
capitalization remain consistent with other messages.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@resources/src/main/res/values/strings.xml`:
- Around line 1173-1193: Update the "connection_lost" string resource value to
use "cloning" instead of "download" so the wording matches the clone flow used
in CloneRepositoryViewModel.kt; locate the string with name "connection_lost" in
strings.xml and change its text to "Connection lost during cloning. Please check
your internet connection and try again." ensuring the exact punctuation and
capitalization remain consistent with other messages.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f070c6f6-f76d-4bb3-b738-baf1a612b8b4

📥 Commits

Reviewing files that changed from the base of the PR and between b6fcdf3 and 03f6988.

📒 Files selected for processing (1)
  • resources/src/main/res/values/strings.xml

@dara-abijo-adfa dara-abijo-adfa merged commit 0b71c7f into stage Mar 27, 2026
2 checks passed
@dara-abijo-adfa dara-abijo-adfa deleted the ADFA-3412-update-git-terms branch March 27, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants