ADFA-3629 Changes logo in notifications

[hal-eisen-adfa]

Had to be careful with the scaling and transparency

[coderabbitai]

📝 Walkthrough

Release Notes

Changes

• Updated notification icon across Gradle build service and ADB pairing service from ic_launcher_fg_vector to a new ic_cogo_notification icon
• Added new vector drawable resource (ic_cogo_notification.xml) featuring a stylized smartphone frame with globe graphic
• Icon includes attention to scaling and transparency as noted in the PR description

Risks & Best Practices

• Notification icon complexity: The new icon combines a smartphone frame with a globe graphic, which may be too detailed to render clearly as a 24dp notification icon. Notification icons should typically be simple and easily recognizable at small sizes. Visual testing on actual devices is recommended to verify readability.
• High viewport scale: The drawable uses a 413.2 × 413.2 viewport, which may introduce scaling artifacts. This should be validated to ensure proper rendering without distortion.
• Wide impact: The icon change affects multiple critical services (Gradle build notifications and ADB pairing notifications). While consistency is good, the scope of change warrants thorough testing across different Android versions and device types.

Walkthrough

Updates notification small icons across Gradle build and ADB pairing services from ic_launcher_fg_vector to a new ic_cogo_notification drawable. Adds the new vector drawable resource defining a 24dp smartphone-with-globe icon.

Changes

Cohort / File(s)	Summary
Notification Icon Updates app/src/main/java/com/itsaky/androidide/services/builder/GradleBuildService.kt, subprojects/shizuku-manager/src/main/java/moe/shizuku/manager/adb/AdbPairingService.kt	Replaced notification small icon resource reference from R.drawable.ic_launcher_fg_vector to R.drawable.ic_cogo_notification across multiple notification variants (Gradle build notifications and ADB pairing service notifications).
New Drawable Resource resources/src/main/res/drawable/ic_cogo_notification.xml	Added new 24dp vector drawable depicting a smartphone frame with a globe graphic, using white fill color and horizontal translation for centered alignment within the 413.2 × 413.2 viewport.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

• jomen-adfa
• Daniel-ADFA
• itsaky-adfa

Poem

🐰 A new icon hops into view,
Where notifications shine bright and true,
Globe-phone frames in vector delight,
Replacing the old with polished light,
Consistency spreads, our services align! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: replacing the notification icon across the codebase with a new logo.
Description check	✅ Passed	The description is related to the changeset, mentioning the care needed for scaling and transparency of the new logo resource.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ADFA-3629-Update-logo-in-system-generated-dialogs-and-notifications

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

resources/src/main/res/drawable/ic_cogo_notification.xml (1)

1-29: Well-structured notification icon with appropriate monochrome design.

The vector drawable correctly follows Android notification icon guidelines with 24dp dimensions and white monochrome paths. The use of evenOdd fillType for the phone frame creates a clean screen cutout effect, and the centering calculation via translateX="95.375" properly centers the phone within the square viewport.

Given the complexity of the globe path (line 24) and the small display size of notification icons (typically 24-48px), you may want to verify that the icon renders clearly and recognizably in actual notification contexts across different screen densities.

🔍 Verification approach

Test the icon appearance by:

1. Building and running on devices with different screen densities (mdpi, hdpi, xxhdpi, xxxhdpi)
2. Checking the status bar notification icon clarity
3. Verifying the notification drawer display
4. Confirming the icon is recognizable when reduced to ~24px

If the globe detail becomes unclear at small sizes, consider simplifying the globe path or increasing line weights.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@resources/src/main/res/drawable/ic_cogo_notification.xml` around lines 1 -
29, Notification icon may be too detailed for small notification sizes: simplify
or swap the complex globe path to ensure recognizability at ~24px. Locate the
globe path (comment "Globe (white)" / path whose pathData begins with
"M107.8,126.57...") and either (1) replace that long pathData with a simplified,
lower‑node silhouette version (remove tiny curves and reduce nodes) or (2)
provide an alternate simplified drawable used for notifications and reference it
instead; keep the phone frame path with android:fillType="evenOdd" and the
translateX="95.375" centering unchanged. Ensure after changes you test rendering
at mdpi/hdpi/xxhdpi to confirm clarity.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@resources/src/main/res/drawable/ic_cogo_notification.xml`:
- Around line 1-29: Notification icon may be too detailed for small notification
sizes: simplify or swap the complex globe path to ensure recognizability at
~24px. Locate the globe path (comment "Globe (white)" / path whose pathData
begins with "M107.8,126.57...") and either (1) replace that long pathData with a
simplified, lower‑node silhouette version (remove tiny curves and reduce nodes)
or (2) provide an alternate simplified drawable used for notifications and
reference it instead; keep the phone frame path with android:fillType="evenOdd"
and the translateX="95.375" centering unchanged. Ensure after changes you test
rendering at mdpi/hdpi/xxhdpi to confirm clarity.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 62175644-2385-4d92-8cd5-a6ea20bccd15

📥 Commits

Reviewing files that changed from the base of the PR and between 4ff3344 and 4e0b067.

📒 Files selected for processing (3)

• app/src/main/java/com/itsaky/androidide/services/builder/GradleBuildService.kt
• resources/src/main/res/drawable/ic_cogo_notification.xml
• subprojects/shizuku-manager/src/main/java/moe/shizuku/manager/adb/AdbPairingService.kt

[itsaky-adfa]

We could also update the notification icon for the terminal service which currently shows the Termux icon. It's located at termux/termux-app/src/main/res/drawable/ic_service_notification.xml and referenced in TermuxService.java.

[hal-eisen-adfa]

We could also update the notification icon for the terminal service which currently shows the Termux icon. It's located at termux/termux-app/src/main/res/drawable/ic_service_notification.xml and referenced in TermuxService.java.

Great idea - thank you! I'll do another PR for that