Skip to content

ADFA-4029: upgrade to latest kotlin-android#1314

Merged
itsaky-adfa merged 2 commits into
stagefrom
fix/ADFA-4029
May 20, 2026
Merged

ADFA-4029: upgrade to latest kotlin-android#1314
itsaky-adfa merged 2 commits into
stagefrom
fix/ADFA-4029

Conversation

@itsaky-adfa
Copy link
Copy Markdown
Contributor

@itsaky-adfa itsaky-adfa commented May 18, 2026

Fixes ADFA-4029 caused due to missing java.lang.ClassValue class on Android API <= 33. See appdevforall/kotlin-android@414445c for the actual fix in the Kotlin compiler.

See ADFA-4029 for more details.

Fixes ADFA-4029 caused due to missing java.lang.ClassValue class on Android API <= 33. See appdevforall/kotlin-android@414445c for the actual fix in the Kotlin compiler

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>
@itsaky-adfa itsaky-adfa requested a review from a team May 18, 2026 19:03
@itsaky-adfa itsaky-adfa self-assigned this May 18, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1be44022-5866-4caa-be28-1e989175ba64

📥 Commits

Reviewing files that changed from the base of the PR and between 2c9224e and 49089b8.

📒 Files selected for processing (1)
  • subprojects/kotlin-analysis-api/build.gradle.kts

📝 Walkthrough

Release Notes

  • Upgraded kotlin-android external dependency to version 2.3.255 (tag: v2.3.255-414445c) to address ADFA-4029
  • Fixed ClassValue compatibility issue on Android API <= 33 through the latest Kotlin compiler fix included in commit 414445c of the appdevforall/kotlin-android repository
  • Updated kotlin-analysis-api build configuration with SHA256 checksum verification for the external JAR asset (a98c4b3a3952799e1703ecc0444ac49bce66042b2c0b689d7e4c4b5b35369c3a)

Risks & Best Practices

  • External dependency risk: The kotlin-android JAR is sourced from an external GitHub release. Ensure the release and checksum are verified before merging
  • Fork dependency: The dependency is from a custom fork (appdevforall/kotlin-android) rather than the upstream Kotlin project. Document the rationale and ensure maintenance plan is in place for divergence from upstream
  • Availability risk: The build depends on GitHub releases remaining available. Consider mirroring critical artifacts internally for production builds
  • Version specificity: The tag includes both version and commit hash, which provides good traceability but couples the build to a specific Kotlin compiler patch

Walkthrough

The PR updates the kt-android external dependency in the Kotlin Analysis API build configuration by recomputing the ktAndroidTag from the existing ktAndroidVersion and updating the corresponding artifact checksum to match the new artifact.

Changes

kt-android Dependency Update

Layer / File(s) Summary
kt-android artifact reference update
subprojects/kotlin-analysis-api/build.gradle.kts
The ktAndroidTag tag computation is updated and the sha256Checksum for the kt-android jar dependency is revised to match the new artifact.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • appdevforall/CodeOnTheGo#1286: Both PRs modify subprojects/kotlin-analysis-api/build.gradle.kts by updating the ktAndroidTag/ktAndroidVersion-derived "kt-android" download reference and the corresponding sha256Checksum for the same artifact.
  • appdevforall/CodeOnTheGo#1307: Both PRs modify the same Gradle dependency in subprojects/kotlin-analysis-api/build.gradle.kts by updating ktAndroidTag and the kt-android jar's sha256Checksum.

Suggested reviewers

  • Daniel-ADFA
  • jatezzz

Poem

🐰 A checksum and a tag align,
Like carrots in a garden line,
The artifact now fresh and new,
Dependencies refreshed through and through! 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: upgrading to the latest kotlin-android version to fix issue ADFA-4029.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of the kotlin-android upgrade and referencing the specific issue being fixed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ADFA-4029

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@itsaky-adfa itsaky-adfa merged commit ccd2a61 into stage May 20, 2026
2 checks passed
@itsaky-adfa itsaky-adfa deleted the fix/ADFA-4029 branch May 20, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants