Skip to content

ADFA-3840 | Hide fullscreen button behind bottom sheet#1315

Merged
jatezzz merged 1 commit into
stagefrom
fix/ADFA-3840-hide-fullscreen-button
May 18, 2026
Merged

ADFA-3840 | Hide fullscreen button behind bottom sheet#1315
jatezzz merged 1 commit into
stagefrom
fix/ADFA-3840-hide-fullscreen-button

Conversation

@jatezzz
Copy link
Copy Markdown
Collaborator

@jatezzz jatezzz commented May 18, 2026

Description

Reordered the views within the CoordinatorLayout in both portrait and landscape content_editor.xml files. By moving the EditorBottomSheet and diagnosticInfo definitions after btn_fullscreen_toggle, the bottom sheet will now draw on top of the fullscreen button. This ensures the editor's fullscreen button is no longer visible or clickable when the bottom sheet is active.

Details

Screen.Recording.2026-05-18.at.3.16.53.PM.mov

Ticket

ADFA-3840

Observation

This fix relies on Android's default drawing order (last declared view is drawn on top) to naturally obscure the button without needing to programmatically toggle its visibility state in the code.

@jatezzz jatezzz requested review from a team, Daniel-ADFA and dara-abijo-adfa May 18, 2026 20:18
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

Review Change Stack

Warning

Rate limit exceeded

@jatezzz has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 55 minutes and 33 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1eb772cd-6fb6-4995-b97f-b3bdc95e5840

📥 Commits

Reviewing files that changed from the base of the PR and between 52e4b87 and 7d8c9d1.

📒 Files selected for processing (2)
  • app/src/main/res/layout-land/content_editor.xml
  • app/src/main/res/layout/content_editor.xml
📝 Walkthrough

Walkthrough

Both editor layout XML files (portrait and landscape) are reorganized to place a fullscreen toggle button before the editor bottom sheet and diagnostic info views, reordering elements within the CoordinatorLayout view hierarchy.

Changes

Editor Layout View Hierarchy Reordering

Layer / File(s) Summary
Portrait layout view reordering
app/src/main/res/layout/content_editor.xml
An ImageButton for fullscreen toggling is positioned immediately after the main editor container, and the EditorBottomSheet and diagnostic info include are relocated to follow that button instead of appearing earlier.
Landscape layout view reordering
app/src/main/res/layout-land/content_editor.xml
The same reordering is applied: the EditorBottomSheet and diagnostic info views are removed from their earlier position and reinserted after the fullscreen toggle button to maintain consistent hierarchy across both layout variants.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • Daniel-ADFA
  • jomen-adfa
  • itsaky-adfa
  • dara-abijo-adfa

Poem

🐰 A button hops forward, bold and bright,
While sheets and sheets arrange just right.
Both portrait and land, now in line,
The layout's flow is now divine! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: reordering views so the bottom sheet draws on top of the fullscreen button, which is the primary objective of this PR.
Description check ✅ Passed The description is directly related to the changeset, explaining the view reordering in both layout files and the intended visual effect of hiding the fullscreen button behind the bottom sheet.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ADFA-3840-hide-fullscreen-button

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Moved bottom sheet below fullscreen button in layout XML to ensure correct z-ordering.
@jatezzz jatezzz force-pushed the fix/ADFA-3840-hide-fullscreen-button branch from 52e4b87 to 7d8c9d1 Compare May 18, 2026 21:31
@jatezzz jatezzz merged commit de44892 into stage May 18, 2026
2 checks passed
@jatezzz jatezzz deleted the fix/ADFA-3840-hide-fullscreen-button branch May 18, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants