Skip to content

ADFA-4058: update plugin build.gradle api version to match on-device compiler#1322

Merged
Daniel-ADFA merged 3 commits into
stagefrom
ADFA-4058
May 20, 2026
Merged

ADFA-4058: update plugin build.gradle api version to match on-device compiler#1322
Daniel-ADFA merged 3 commits into
stagefrom
ADFA-4058

Conversation

@Daniel-ADFA
Copy link
Copy Markdown
Contributor

No description provided.

@Daniel-ADFA Daniel-ADFA requested a review from a team May 20, 2026 08:03
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 25e970da-cea3-437d-a271-cd35130df1d2

📥 Commits

Reviewing files that changed from the base of the PR and between d4e0f15 and 654d337.

📒 Files selected for processing (1)
  • plugin-api/build.gradle.kts
✅ Files skipped from review due to trivial changes (1)
  • plugin-api/build.gradle.kts

📝 Walkthrough

Release Notes

  • Pinned Kotlin compiler settings in plugin-api/build.gradle.kts:
    • apiVersion = KotlinVersion.KOTLIN_2_1
    • languageVersion = KotlinVersion.KOTLIN_2_1
    • Comment added: to match the on-device Kotlin compiler so plugin-api.jar can be consumed without -Xskip-metadata-version-check

Risks & Best-practices

  • Version lock: Binding apiVersion/languageVersion to 2.1 requires updating this build file whenever the on-device compiler is upgraded.
  • Maintenance burden: Future Kotlin upgrades on-device must be mirrored here to avoid metadata incompatibility.
  • Best practice note: Pinning compiler versions is acceptable for compatibility but ensure a process exists to review and update these pins when on-device tooling advances.

Walkthrough

The plugin-api Gradle build configuration is updated to pin both Kotlin compiler apiVersion and languageVersion to KotlinVersion.KOTLIN_2_1, ensuring the generated plugin-api.jar metadata matches the on-device Kotlin compiler without requiring -Xskip-metadata-version-check.

Changes

Kotlin Compiler Configuration

Layer / File(s) Summary
Kotlin compiler version pinning
plugin-api/build.gradle.kts
Kotlin compiler apiVersion and languageVersion are pinned to KotlinVersion.KOTLIN_2_1 in the compiler options block with an explanatory comment.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • jomen-adfa

Poem

🐰 I pin the Kotlin line with care,
2.1 set with a gentle stare,
plugin jars hum without a hitch,
no metadata skips to twitch,
a tidy hop, build bliss to share.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to evaluate whether it relates to the changeset. Add a brief pull request description explaining the rationale and impact of updating the Kotlin compiler version pinning.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: updating the Kotlin compiler API version in the plugin build configuration to match the on-device compiler.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ADFA-4058

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Daniel-ADFA Daniel-ADFA merged commit 2dee111 into stage May 20, 2026
2 checks passed
@Daniel-ADFA Daniel-ADFA deleted the ADFA-4058 branch May 20, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants