Skip to content

ADFA-4063 Fix typo in debug message in Pebble template handler#1325

Merged
davidschachterADFA merged 1 commit into
stagefrom
fix/ADFA-4063
May 20, 2026
Merged

ADFA-4063 Fix typo in debug message in Pebble template handler#1325
davidschachterADFA merged 1 commit into
stagefrom
fix/ADFA-4063

Conversation

@alexmmiller
Copy link
Copy Markdown
Collaborator

@alexmmiller alexmmiller commented May 20, 2026

Removes a typo from the debug messages in the web server's Pebble template handler

Ticket: https://appdevforall.atlassian.net/browse/ADFA-4063

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

Review Change Stack

📝 Walkthrough

Release Notes

  • Fixed typo in Pebble template handler debug messages: Corrected SLF4J format strings in the instantiatePebbleTemplate method in WebServer.kt. Four debug log messages contained an extra closing brace } in the compression placeholder, which would have produced malformed logging output. The fixes were applied to:
    • Template cache miss log message (line 419)
    • Template not found log message (line 432)
    • Duplicate template detection log message (line 442)
    • Template not found log message in cursor check (line 452)

Risk Assessment

  • No risk: This is a debug logging-only change that does not affect runtime behavior, functionality, or business logic. The fix corrects logging format strings to produce properly formatted debug output, improving observability without any impact to the application.

Walkthrough

Fixed three malformed SLF4J format string placeholders in the instantiatePebbleTemplate method's debug logging. Each error path (template not found, duplicate templates, and missing database entry) had an extra closing brace in the compression parameter placeholder; corrected all three to use proper SLF4J {} syntax.

Changes

Logging Format Fixes

Layer / File(s) Summary
SLF4J placeholder syntax corrections
app/src/main/java/com/itsaky/androidide/localWebServer/WebServer.kt
Three debug log messages in instantiatePebbleTemplate error paths had malformed placeholder braces for the compression parameter; corrected the format strings to use proper SLF4J {} syntax across template-not-found, duplicate-template, and database-lookup error cases.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • appdevforall/CodeOnTheGo#1318: Both PRs touch WebServer.kt's instantiatePebbleTemplate method; the previous PR introduced the method with logging, this PR corrects the format string syntax in those logs.

Suggested reviewers

  • jatezzz
  • davidschachterADFA

Poem

🐰 A tiny hop through logging lines,
Three braces fixed to align,
SLF4J now logs with grace,
No malformed strings in this place! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: fixing a typo in debug messages within the Pebble template handler.
Description check ✅ Passed The description is directly related to the changeset, accurately describing the fix for typos in debug messages in the Pebble template handler.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ADFA-4063

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
app/src/main/java/com/itsaky/androidide/localWebServer/WebServer.kt (1)

419-419: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Inconsistent fix: missed the same typo on this line.

Line 419 still contains the malformed SLF4J placeholder compression {}} (extra closing brace), while lines 432, 442, and 452 were corrected. All four debug statements should use the same format.

🔧 Proposed fix
-                "Template cache miss for ID {}, path {}, MIME type {}, compression {}}",
+                "Template cache miss for ID {}, path {}, MIME type {}, compression {}",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/main/java/com/itsaky/androidide/localWebServer/WebServer.kt` at line
419, The debug message string "Template cache miss for ID {}, path {}, MIME type
{}, compression {}}" contains an extra closing brace; update that instance in
WebServer.kt so the placeholder reads "compression {}" (matching the corrected
debug statements at the other occurrences) to restore proper SLF4J placeholder
formatting for the template cache miss log.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@app/src/main/java/com/itsaky/androidide/localWebServer/WebServer.kt`:
- Line 419: The debug message string "Template cache miss for ID {}, path {},
MIME type {}, compression {}}" contains an extra closing brace; update that
instance in WebServer.kt so the placeholder reads "compression {}" (matching the
corrected debug statements at the other occurrences) to restore proper SLF4J
placeholder formatting for the template cache miss log.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ec25e7a2-0341-455c-b909-3a3128f155a0

📥 Commits

Reviewing files that changed from the base of the PR and between 2dee111 and 5fe98df.

📒 Files selected for processing (1)
  • app/src/main/java/com/itsaky/androidide/localWebServer/WebServer.kt

@alexmmiller alexmmiller requested a review from jatezzz May 20, 2026 20:05
@davidschachterADFA davidschachterADFA merged commit 7f8b506 into stage May 20, 2026
2 checks passed
@davidschachterADFA davidschachterADFA deleted the fix/ADFA-4063 branch May 20, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants