fix(ADFA-2148): Do not truncate swipe hint text#1336
Conversation
📝 WalkthroughRelease Notes
Potential Risks
WalkthroughUpdated ChangesBuild Status Layout Sizing
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
app/src/main/res/layout/layout_editor_build_status.xml (1)
40-52: ⚡ Quick winValidate
swipe_hintrendering with the longest@string/msg_swipe_uplocalizations
Droppingandroid:maxLinesshould address truncation, butmsg_swipe_uplength varies across locales (longest observed ~157 chars invalues-bn-rIN, then ~133 invalues-hi-rIN, and ~123 invalues-ru-rRU). Testlayout_editor_build_status.xmlin those languages to ensure the text wraps cleanly (no truncation/overlap) and the combined height withstatusTextstill fits within the parent constraints.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/src/main/res/layout/layout_editor_build_status.xml` around lines 40 - 52, The swipe_hint TextView can get truncated by tight constraints for long localizations; update layout_editor_build_status.xml so the TextView with id swipe_hint does not have an android:maxLines limiting wrapping (remove any maxLines), keep width="0dp" and height="wrap_content", and relax its vertical constraint by removing app:layout_constraintBottom_toBottomOf="parent" (leave it constrained to statusText via app:layout_constraintTop_toBottomOf="`@id/statusText`" or use a vertical chain) so it can grow with long strings; then test in values-bn-rIN, values-hi-rIN and values-ru-rRU and adjust constraints if the combined height of swipe_hint and statusText exceeds the parent.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@app/src/main/res/layout/layout_editor_build_status.xml`:
- Around line 40-52: The swipe_hint TextView can get truncated by tight
constraints for long localizations; update layout_editor_build_status.xml so the
TextView with id swipe_hint does not have an android:maxLines limiting wrapping
(remove any maxLines), keep width="0dp" and height="wrap_content", and relax its
vertical constraint by removing app:layout_constraintBottom_toBottomOf="parent"
(leave it constrained to statusText via
app:layout_constraintTop_toBottomOf="`@id/statusText`" or use a vertical chain) so
it can grow with long strings; then test in values-bn-rIN, values-hi-rIN and
values-ru-rRU and adjust constraints if the combined height of swipe_hint and
statusText exceeds the parent.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 92094083-7bf3-486b-991b-ec0118782c0e
📒 Files selected for processing (1)
app/src/main/res/layout/layout_editor_build_status.xml
Remove
maxLinesfrom swipe hint text to fix truncated text