Skip to content

ADFA-3989: fix missing AWS CLI from weekly release#1339

Merged
Daniel-ADFA merged 1 commit into
stagefrom
ADFA-3989-fix-aws-v2
May 26, 2026
Merged

ADFA-3989: fix missing AWS CLI from weekly release#1339
Daniel-ADFA merged 1 commit into
stagefrom
ADFA-3989-fix-aws-v2

Conversation

@Daniel-ADFA
Copy link
Copy Markdown
Contributor

No description provided.

@Daniel-ADFA Daniel-ADFA requested a review from a team May 26, 2026 15:35
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 26, 2026

Review Change Stack

📝 Walkthrough

Release Notes

  • Added AWS CLI v2 to Flox base environment (flox/base/.flox/env/manifest.toml): The awscli2 package is now installed in the development environment to support AWS S3 operations

  • Updated weekly release workflow to use Flox environment for AWS CLI operations (.github/workflows/weekly-release.yml):

    • Modified upload-r2 job to execute the Cloudflare R2 upload command within the flox/base environment using shell: flox activate -d flox/base -- bash -eo pipefail {0}
    • This ensures AWS CLI commands run with the correct tooling available
  • Simplified checkout configurations: Multiple actions/checkout@v4 steps now rely on default ref behavior instead of explicitly specifying ref: main, maintaining consistent authentication settings via persist-credentials: false

Risks & Best Practices Notes

  • ⚠️ Implicit ref defaults: Removing explicit ref: main specifications relies on GitHub Actions default behavior. While this typically defaults to the base branch, this should be monitored to ensure checkout operations target the intended refs across different workflow contexts

  • ⚠️ Flox environment dependency: AWS operations now depend on successful Flox environment activation. If the flox/base environment becomes unavailable or invalid, the R2 upload step will fail. Consider documenting fallback procedures

Walkthrough

The weekly-release workflow removes explicit ref: main specifications from multiple jobs' checkout steps, relying on workflow trigger defaults instead. The Cloudflare R2 upload step is updated to run explicitly under the flox/base environment with a new awscli2 package dependency added to the manifest.

Changes

Weekly Release Workflow Configuration

Layer / File(s) Summary
Checkout ref standardization across jobs
.github/workflows/weekly-release.yml
Removes ref: main settings from actions/checkout@v4 in prepare, pull-apk, release-codeonthego, upload-r2, and finalize jobs, allowing the workflow to use the default ref behavior for release-triggered runs.
R2 upload environment and dependencies
.github/workflows/weekly-release.yml, flox/base/.flox/env/manifest.toml
Adds explicit flox activate -d flox/base shell wrapper to the Cloudflare R2 upload step and includes awscli2 package in the flox/base manifest to provide AWS CLI for upload operations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • appdevforall/CodeOnTheGo#1328: Both PRs modify .github/workflows/weekly-release.yml's actions/checkout configuration and wrap multiple release shell steps to run under flox/base.
  • appdevforall/CodeOnTheGo#1290: Introduces the weekly release workflow; this PR refines checkout ref defaults and adds the flox/base shell wrapper for the upload-r2 step.

Suggested reviewers

  • hal-eisen-adfa
  • dara-abijo-adfa

Poem

🐇 A rabbit hops through workflows with care,
Removing refs that aren't quite fair,
With flox and AWS tools at hand,
R2 uploads now go as planned! 📦✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author. Add a brief description explaining why AWS CLI is needed in the weekly release workflow and the impact of this change.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title directly addresses the main change: adding AWS CLI to fix the weekly release workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ADFA-3989-fix-aws-v2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/weekly-release.yml:
- Around line 228-231: The workflow currently uses the mutable tag
actions/checkout@v4 which can drift; update the checkout step to pin to a
specific full commit SHA instead of the v4 tag by replacing "uses:
actions/checkout@v4" with "uses: actions/checkout@<full-commit-sha>" (use the
latest known commit SHA for actions/checkout) so the checkout step is immutable
and reproducible; ensure the change is applied to the checkout step shown in the
diff.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ff6ee96d-2a9a-4655-a972-430365f48c63

📥 Commits

Reviewing files that changed from the base of the PR and between a331093 and e2438ea.

⛔ Files ignored due to path filters (1)
  • flox/base/.flox/env/manifest.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • .github/workflows/weekly-release.yml
  • flox/base/.flox/env/manifest.toml

Comment thread .github/workflows/weekly-release.yml
@Daniel-ADFA Daniel-ADFA merged commit 96740f5 into stage May 26, 2026
4 checks passed
@Daniel-ADFA Daniel-ADFA deleted the ADFA-3989-fix-aws-v2 branch May 26, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants